735517 - Web Apps icon always appears when other popup notifications appear

Status: VERIFIED FIXED

(Firefox Graveyard :: Web Apps, defect)

Description

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

Enviroment:
Windows 7 (x64)
http://hg.mozilla.org/mozilla-central/rev/8d1c74566a0b

STR:
Show popup notification. (e.g. http://maps.google.com/ 's geolocation)

Result:
Show web app notification icon.

This bug is caused by http://hg.mozilla.org/mozilla-central/rev/374977a5f8c6.
So the following code is wrong. This element's class attribute should be "notification-anchor-icon".

/browser/base/content/browser.xul

<image id="webapps-notification-icon" class="webapps-anchor-icon" role="button"/>

Comment 1

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

Attachment: proposed patch

Comment 2

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

Attachment: proposed patch

Comment 3

[[:fabrice] Fabrice Desré]

nice catch!

Comment 5

[:Felipe Gomes (needinfo for replies!)]

Thanks Ohzeki.

http://hg.mozilla.org/mozilla-central/rev/629298cfd480

Comment 6

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 605592 [details] [diff] [review]
proposed patch

[Approval Request Comment]
This bug is present in Aurora since it landed before the uplift yesterday. Simple patch to fix the webapps icon showing during unrelated popup notifications

Comment 7

[Alex Keybl [:akeybl]]

Comment on attachment 605592 [details] [diff] [review]
proposed patch

[Triage Comment]
Low risk fix in support of webapp notifications. Approved for Aurora 13.

Comment 8

[:Felipe Gomes (needinfo for replies!)]

http://hg.mozilla.org/releases/mozilla-aurora/rev/663a0383af8d

Comment 9

[Jason Smith [:jsmith]]

Verified on Nightly.

Comment 10

[Jason Smith [:jsmith]]

Also verified on Aurora.