The default bug view has changed. See this FAQ.

Web Apps icon always appears when other popup notifications appear

VERIFIED FIXED in Firefox 14

Status

Firefox Graveyard
Web Apps
VERIFIED FIXED
5 years ago
a year ago

People

(Reporter: tetsuharu, Unassigned)

Tracking

({regression})

Trunk
Firefox 14
regression
Bug Flags:
in-moztrap -

Details

Attachments

(1 attachment, 1 obsolete attachment)

Enviroment:
Windows 7 (x64)
http://hg.mozilla.org/mozilla-central/rev/8d1c74566a0b

STR:
Show popup notification. (e.g. http://maps.google.com/ 's geolocation)

Result:
Show web app notification icon.

This bug is caused by http://hg.mozilla.org/mozilla-central/rev/374977a5f8c6.
So the following code is wrong. This element's class attribute should be "notification-anchor-icon".

/browser/base/content/browser.xul

<image id="webapps-notification-icon" class="webapps-anchor-icon" role="button"/>
(Reporter)

Updated

5 years ago
Blocks: 697006
Created attachment 605591 [details]
proposed patch
Created attachment 605592 [details] [diff] [review]
proposed patch
Attachment #605591 - Attachment is obsolete: true
Attachment #605592 - Flags: review+
nice catch!

Updated

5 years ago
Keywords: checkin-needed
(Reporter)

Updated

5 years ago
Keywords: regression
Duplicate of this bug: 735680
Summary: Show always Web Apps icon when showing popup notification. → Web Apps icon always appears when other popup notifications appear
Keywords: checkin-needed

Updated

5 years ago
Attachment #605592 - Flags: review+
Thanks Ohzeki.

http://hg.mozilla.org/mozilla-central/rev/629298cfd480
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Component: General → Web Apps
OS: Windows 7 → All
QA Contact: general → webapps
Hardware: x86_64 → All
Resolution: --- → FIXED
Comment on attachment 605592 [details] [diff] [review]
proposed patch

[Approval Request Comment]
This bug is present in Aurora since it landed before the uplift yesterday. Simple patch to fix the webapps icon showing during unrelated popup notifications
Attachment #605592 - Flags: approval-mozilla-aurora?
Blocks: 735571

Comment 7

5 years ago
Comment on attachment 605592 [details] [diff] [review]
proposed patch

[Triage Comment]
Low risk fix in support of webapp notifications. Approved for Aurora 13.
Attachment #605592 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
http://hg.mozilla.org/releases/mozilla-aurora/rev/663a0383af8d
Verified on Nightly.
Status: RESOLVED → VERIFIED
Also verified on Aurora.

Updated

5 years ago
Blocks: 731054

Updated

5 years ago
status-firefox13: --- → verified
Target Milestone: --- → Firefox 14

Updated

5 years ago
No longer blocks: 731054

Updated

5 years ago
Flags: in-moztrap?(jsmith)

Updated

5 years ago
QA Contact: jsmith

Updated

5 years ago
Flags: in-moztrap?(jsmith) → in-moztrap-

Updated

4 years ago
No longer blocks: 735571
(Assignee)

Updated

a year ago
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.