Closed Bug 735536 Opened 9 years ago Closed 9 years ago

B2G SMS DB: Use new fangled IndexedDB string constants

Categories

(Core :: DOM: Device Interfaces, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla14

People

(Reporter: philikon, Assigned: ferjm)

References

Details

(Whiteboard: [good first bug][lang=js][mentor=philikon])

Attachments

(1 file, 2 obsolete files)

Also c.f. bug 735357 for inspiration (not that the fix is that complicated...)
Blocks: 712809
No longer blocks: 733265
Duplicate of this bug: 736009
Assignee: nobody → ferjmoreno
Attached patch Fix v1 (obsolete) — Splinter Review
Attachment #606155 - Flags: review?(philipp)
Attached patch Fix v1 (obsolete) — Splinter Review
Sorry, the patch was corrupted and wouldn´t apply.
Attachment #606155 - Attachment is obsolete: true
Attachment #606155 - Flags: review?(philipp)
Attachment #606244 - Flags: review?(philipp)
Attachment #606244 - Attachment is patch: true
Comment on attachment 606244 [details] [diff] [review]
Fix v1

I would actually prefer if we const'ed those values, e.g.:

  const READONLY = "readonly";

etc. Looks good otherwise!
Attachment #606244 - Flags: review?(philipp) → feedback+
Blocks: 736376
Attached patch Fix v2Splinter Review
Yes, I thought about the constants, but the ContactDB patch didn´t use constants, so I chose to also don´t use it. Anyway, I also prefer this way.
Attachment #606244 - Attachment is obsolete: true
Attachment #606669 - Flags: review?(philipp)
Attachment #606669 - Flags: review?(philipp) → review+
https://hg.mozilla.org/mozilla-central/rev/c0e783b4cc4b
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
Duplicate of this bug: 736376
You need to log in before you can comment on or make changes to this bug.