735536 - B2G SMS DB: Use new fangled IndexedDB string constants

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Philipp von Weitershausen [:philikon]]

See bug 735094.

Comment 1

[Philipp von Weitershausen [:philikon]]

Also c.f. bug 735357 for inspiration (not that the fix is that complicated...)

Comment 3

[Fernando Jiménez Moreno [:ferjm]]

Attachment: Fix v1

Comment 4

[Fernando Jiménez Moreno [:ferjm]]

Attachment: Fix v1

Sorry, the patch was corrupted and wouldn´t apply.

Comment 5

[Philipp von Weitershausen [:philikon]]

Comment on attachment 606244 [details] [diff] [review]
Fix v1

I would actually prefer if we const'ed those values, e.g.:

  const READONLY = "readonly";

etc. Looks good otherwise!

Comment 6

[Fernando Jiménez Moreno [:ferjm]]

Attachment: Fix v2

Yes, I thought about the constants, but the ContactDB patch didn´t use constants, so I chose to also don´t use it. Anyway, I also prefer this way.

Comment 7

[Philipp von Weitershausen [:philikon]]

https://hg.mozilla.org/mozilla-central/rev/c0e783b4cc4b