B2G SMS DB: Use new fangled IndexedDB string constants

RESOLVED FIXED in mozilla14

Status

()

Core
DOM: Device Interfaces
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: philikon, Assigned: ferjm)

Tracking

Trunk
mozilla14
ARM
Gonk (Firefox OS)
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug][lang=js][mentor=philikon])

Attachments

(1 attachment, 2 obsolete attachments)

See bug 735094.
Also c.f. bug 735357 for inspiration (not that the fix is that complicated...)
(Reporter)

Updated

6 years ago
Blocks: 712809
No longer blocks: 733265
(Reporter)

Updated

6 years ago
Duplicate of this bug: 736009
(Assignee)

Updated

6 years ago
Assignee: nobody → ferjmoreno
(Assignee)

Comment 3

6 years ago
Created attachment 606155 [details] [diff] [review]
Fix v1
Attachment #606155 - Flags: review?(philipp)
(Assignee)

Comment 4

6 years ago
Created attachment 606244 [details] [diff] [review]
Fix v1

Sorry, the patch was corrupted and wouldn´t apply.
Attachment #606155 - Attachment is obsolete: true
Attachment #606155 - Flags: review?(philipp)
Attachment #606244 - Flags: review?(philipp)
(Assignee)

Updated

6 years ago
Attachment #606244 - Attachment is patch: true
Comment on attachment 606244 [details] [diff] [review]
Fix v1

I would actually prefer if we const'ed those values, e.g.:

  const READONLY = "readonly";

etc. Looks good otherwise!
Attachment #606244 - Flags: review?(philipp) → feedback+

Updated

6 years ago
Blocks: 736376
(Assignee)

Comment 6

6 years ago
Created attachment 606669 [details] [diff] [review]
Fix v2

Yes, I thought about the constants, but the ContactDB patch didn´t use constants, so I chose to also don´t use it. Anyway, I also prefer this way.
Attachment #606244 - Attachment is obsolete: true
Attachment #606669 - Flags: review?(philipp)
(Reporter)

Updated

6 years ago
Attachment #606669 - Flags: review?(philipp) → review+
https://hg.mozilla.org/mozilla-central/rev/c0e783b4cc4b
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
Duplicate of this bug: 736376
You need to log in before you can comment on or make changes to this bug.