Closed
Bug 735597
Opened 12 years ago
Closed 12 years ago
static URL is used for weave-password-reset
Categories
(Cloud Services :: General, defect)
Cloud Services
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Andre.Weidemann, Assigned: rfkelly)
Details
Attachments
(1 file)
5.17 KB,
patch
|
telliott
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Windows NT 6.0; rv:10.0.2) Gecko/20100101 Firefox/10.0.2 Build ID: 20120215223356 Steps to reproduce: I set up Firefox Sync on my server (cloned from hg a few days back). Since I only have one IP and one DNS entry for my machine, I set it up under https://<servername>/ff-sync/. This is the Apache config: Alias /media /usr/local/share/weave-sever/deps/server-reg/syncreg/static WSGIProcessGroup sync WSGIDaemonProcess sync user=sync group=nogroup processes=2 threads=25 WSGIPassAuthorization On WSGIScriptAlias /ff-sync /usr/local/share/weave-sever/sync.wsgi Actual results: Syncing contacts and so on works fine, but resetting the password does not. The URL to "weave-password-reset" is hard coded. Resetting the password fails, as soon as you do not run the sync-server on / . Expected results: The request URI should be read and should then be inserted correctly into the POST.
Comment 1•12 years ago
|
||
The URL should be appending weave-password-reset to the server URL. Is that not what you're seeing?
Reporter | ||
Comment 2•12 years ago
|
||
The weave-password-reset URL is append right after the server name. I set up Firefox Sync under this URL on my server https://<servername>/ff-sync/. When accessing the URL to "weave-password-reset", "ff-sync/" is missing from the URL.
Comment 3•12 years ago
|
||
in about:config, what's the value of services.sync.serverURL ?
Reporter | ||
Comment 4•12 years ago
|
||
services.sync.serverURL is set to "https://*****.dyndns.org/ff-sync/" Take a look here: http://imageshack.us/photo/my-images/842/servicessyncserverurl.png/
Assignee | ||
Comment 5•12 years ago
|
||
It looks like the path /weave-password-sync is hard-coded into various templates in the server, but it should be working correctly in the server itself. Can you please try a couple of things? 1) Does accessing https://****.dyndns.org/ff-sync/weave-password-reset correctly produce the password reset form? 2) If you change the hard-coded paths in the following files to match your setup, does it all work correctly? * server-full/deps/server-reg/syncreg/templates/password_ask_reset_form.mako * server-full/deps/server-reg/syncreg/templates/password_reset_form.mako * server-full/deps/server-reg/syncreg/templates/password_reset_mail.mako If that fixes the problem for you, I'll work on replacing the hard-coded paths with something determined dynamically from the request URL.
Assignee | ||
Comment 6•12 years ago
|
||
This patch uses the url-generation facilities of Routes to determine the password reset URL at runtime. Hand-tested on a fresh build of server-full mounted at http://localhost:5000/test, the password reset works successfully after configuring smtp, reset codes etc.
Assignee: nobody → rfkelly
Attachment #626320 -
Flags: review?(telliott)
Updated•12 years ago
|
Attachment #626320 -
Flags: review?(telliott) → review+
Assignee | ||
Comment 7•12 years ago
|
||
http://hg.mozilla.org/services/server-reg/rev/eccf702f6f84
Status: UNCONFIRMED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•