The default bug view has changed. See this FAQ.

Remove AutoClean from mozglue/linker/Utils.h

RESOLVED FIXED in mozilla17

Status

()

Core
mozglue
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: Yoric, Assigned: drexler)

Tracking

unspecified
mozilla17
ARM
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mentor=Yoric][lang=c++])

Attachments

(1 attachment)

Now that we have generic RAII helpers in MFBT, we should get rid of the corresponding original code in mozglue/linker/Utils.h, which does not compile with VC++.
Note: to test that it does not break faulty.lib, add |export MOZ_LINKER=1| to mozconfig and build on Linux desktop.
Actually, it looks like a good candidate for mentored bugs.
Component: XPCOM → XP Toolkit/Widgets: Menus
QA Contact: xpcom → xptoolkit.menus
Whiteboard: [mentor=Yoric][lang=c++]
Component: XP Toolkit/Widgets: Menus → mozglue
OS: Mac OS X → Android
QA Contact: xptoolkit.menus → mozglue
Hardware: x86 → ARM
(Assignee)

Updated

5 years ago
QA Contact: andrew.quartey
(Assignee)

Updated

5 years ago
Assignee: nobody → andrew.quartey
QA Contact: andrew.quartey
(Assignee)

Comment 3

5 years ago
Created attachment 646882 [details] [diff] [review]
patch
Attachment #646882 - Flags: review?(dteller)
(Assignee)

Updated

5 years ago
QA Contact: mozglue
Comment on attachment 646882 [details] [diff] [review]
patch

I'll take this review
Attachment #646882 - Flags: review?(dteller) → review?(mh+mozilla)
Attachment #646882 - Flags: review?(mh+mozilla) → review+
(Assignee)

Comment 5

5 years ago
Sent to inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/3c34aa0c81f7
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/3c34aa0c81f7
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
Depends on: 826173
You need to log in before you can comment on or make changes to this bug.