Get rid of ImportHTMLFromFileToFolder

RESOLVED FIXED in mozilla14

Status

()

Toolkit
Places
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mak, Assigned: mak)

Tracking

({addon-compat, dev-doc-complete})

unspecified
mozilla14
addon-compat, dev-doc-complete
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -
in-litmus -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
bug 735312 is removing the last caller, to this method can die.
(Assignee)

Updated

5 years ago
Assignee: nobody → mak77
Status: NEW → ASSIGNED
(Assignee)

Comment 1

5 years ago
Created attachment 606038 [details] [diff] [review]
patch v1.0

Note that I could do much more cleanup than this, since some internal methods have redundant arguments now.  Though, since the rewrite from hsivonen is pending review and I already commented on some of those there in my last review pass, it's not worth putting more stuff here.  This removal will instead simplify things there, by killing code and clarifying what is left.
Attachment #606038 - Flags: superreview?(gavin.sharp)
Attachment #606038 - Flags: review?(dietrich)
Attachment #606038 - Flags: superreview?(gavin.sharp) → superreview+
Attachment #606038 - Flags: review?(dietrich) → review+
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/8dcabd1aa9c7

Setting addon-compat for the method removal, even if the probability someone uses this is quite low.
Flags: in-testsuite-
Flags: in-litmus-
Keywords: addon-compat
Target Milestone: --- → mozilla14
(Assignee)

Comment 3

5 years ago
and dev-doc-needed in case the interface page needs update
Keywords: dev-doc-needed
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/mozilla-central/rev/8dcabd1aa9c7
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Blocks: 736547
Documentation tweaked:

https://developer.mozilla.org/En/Places_Developer_Guide#HTML_Import.2FExport

The interface wasn't documented at all, but now it is, with these changes noted:

https://developer.mozilla.org/en/XPCOM_Interface_Reference/nsIPlacesImportExportService

Mentioned on Firefox 14 for developers.
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.