The default bug view has changed. See this FAQ.

Fix db migrations in BrowserProvider

RESOLVED FIXED in Firefox 13

Status

()

Firefox for Android
General
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: lucasr, Assigned: lucasr)

Tracking

Trunk
Firefox 14
All
Android
Points:
---

Firefox Tracking Flags

(firefox13 fixed, firefox14 fixed, blocking-fennec1.0 beta+)

Details

Attachments

(2 attachments)

(Assignee)

Description

5 years ago
Two issues:
- Migration to activate history/bookmarks view with images (with no sub-selected) was never active because the db version was not bumped.
- Migrations are simply no being committed because it's missing setTransactionSuccessful() call.
(Assignee)

Comment 1

5 years ago
Created attachment 605737 [details] [diff] [review]
(1/2) Commit DB transaction used by migrations
Attachment #605737 - Flags: review?(mark.finkle)
(Assignee)

Comment 2

5 years ago
Created attachment 605738 [details] [diff] [review]
(2/2) Bump database version to enable more performant views
Attachment #605738 - Flags: review?(mark.finkle)
Attachment #605737 - Flags: review?(mark.finkle) → review+
Attachment #605738 - Flags: review?(mark.finkle) → review+
(Assignee)

Comment 3

5 years ago
Pushed:
http://hg.mozilla.org/integration/mozilla-inbound/rev/ba59b9112f6f
http://hg.mozilla.org/integration/mozilla-inbound/rev/722edd7fe3ee
https://hg.mozilla.org/mozilla-central/rev/ba59b9112f6f
https://hg.mozilla.org/mozilla-central/rev/722edd7fe3ee
Assignee: nobody → lucasr.at.mozilla
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 14
(Assignee)

Updated

5 years ago
tracking-fennec: --- → ?
blocking-fennec1.0: --- → ?
(Assignee)

Updated

5 years ago
Blocks: 708149
(Assignee)

Comment 5

5 years ago
This is a hard dependency to land bug 708149 in Aurora btw. So, this is almost automatically a beta blocker as well.
(Assignee)

Updated

5 years ago
tracking-fennec: ? → ---
Ageed. Please ask for aurora approval.
blocking-fennec1.0: ? → beta+
(Assignee)

Comment 7

5 years ago
Comment on attachment 605737 [details] [diff] [review]
(1/2) Commit DB transaction used by migrations

Mobile-only. Beta blocker.
Attachment #605737 - Flags: approval-mozilla-aurora?
(Assignee)

Comment 8

5 years ago
Comment on attachment 605738 [details] [diff] [review]
(2/2) Bump database version to enable more performant views

Mobile-only. Beta blocker.
Attachment #605738 - Flags: approval-mozilla-aurora?
[Triage Comment]
Can we get a risk assessment here? There have been many issues lately with bookmarks (see https://wiki.mozilla.org/Firefox/Planning/2012-03-21#Desktop), will this help?
(In reply to Lukas Blakk [:lsblakk] from comment #9)
> [Triage Comment]
> Can we get a risk assessment here? There have been many issues lately with
> bookmarks (see
> https://wiki.mozilla.org/Firefox/Planning/2012-03-21#Desktop), will this
> help?

This change has nothing to do with Sync. This change merely makes sure the DB is updated to the newer version. The version that has a much faster awesomebar query. It is a blocker for Fennec13 too.
Comment on attachment 605737 [details] [diff] [review]
(1/2) Commit DB transaction used by migrations

[Triage Comment]
Sorry, just caught that this is a Fennec Native bug, please ignore previous comment and go ahead with this.
Attachment #605737 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Attachment #605738 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/55ac298a9f11
https://hg.mozilla.org/releases/mozilla-aurora/rev/2c0e8e4571c8
status-firefox13: --- → fixed
status-firefox14: --- → fixed
You need to log in before you can comment on or make changes to this bug.