Closed Bug 735660 Opened 11 years ago Closed 11 years ago

Fix db migrations in BrowserProvider

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
All
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox13 fixed, firefox14 fixed, blocking-fennec1.0 beta+)

Status:
RESOLVED FIXED
Milestone:
Firefox 14
Tracking Flags:
Tracking Status
firefox13 --- fixed
firefox14 --- fixed
blocking-fennec1.0 --- beta+

People

(Reporter: lucasr, Assigned: lucasr)

References

Details

Attachments

(2 files)

(1/2) Commit DB transaction used by migrations
1004 bytes, patch
mfinkle
: review+
lsblakk
: approval-mozilla-aurora+
Details | Diff | Splinter Review
(2/2) Bump database version to enable more performant views
1.14 KB, patch
mfinkle
: review+
lsblakk
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
Two issues:
- Migration to activate history/bookmarks view with images (with no sub-selected) was never active because the db version was not bumped.
- Migrations are simply no being committed because it's missing setTransactionSuccessful() call.

        Attachment #605737 -
        Flags: review?(mark.finkle)

        Attachment #605737 -
        Flags: review?(mark.finkle) → review+

        Attachment #605738 -
        Flags: review?(mark.finkle) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/ba59b9112f6f
https://hg.mozilla.org/mozilla-central/rev/722edd7fe3ee
Assignee: nobody → lucasr.at.mozilla
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 14

    
  
tracking-fennec: --- → ?
blocking-fennec1.0: --- → ?

    
  
Blocks: 708149

    
    

    
  
This is a hard dependency to land bug 708149 in Aurora btw. So, this is almost automatically a beta blocker as well.

    
  
tracking-fennec: ? → ---

    
    

    
  
Ageed. Please ask for aurora approval.
blocking-fennec1.0: ? → beta+

    
    

    
  
Comment on attachment 605737 [details] [diff] [review]
(1/2) Commit DB transaction used by migrations

Mobile-only. Beta blocker.

        Attachment #605737 -
        Flags: approval-mozilla-aurora?

    
    

    
  
Comment on attachment 605738 [details] [diff] [review]
(2/2) Bump database version to enable more performant views

Mobile-only. Beta blocker.

        Attachment #605738 -
        Flags: approval-mozilla-aurora?

    
    

    
  
[Triage Comment]
Can we get a risk assessment here? There have been many issues lately with bookmarks (see https://wiki.mozilla.org/Firefox/Planning/2012-03-21#Desktop), will this help?

    
    

    
  
(In reply to Lukas Blakk [:lsblakk] from comment #9)
> [Triage Comment]
> Can we get a risk assessment here? There have been many issues lately with
> bookmarks (see
> https://wiki.mozilla.org/Firefox/Planning/2012-03-21#Desktop), will this
> help?

This change has nothing to do with Sync. This change merely makes sure the DB is updated to the newer version. The version that has a much faster awesomebar query. It is a blocker for Fennec13 too.

    
    

    
  
Comment on attachment 605737 [details] [diff] [review]
(1/2) Commit DB transaction used by migrations

[Triage Comment]
Sorry, just caught that this is a Fennec Native bug, please ignore previous comment and go ahead with this.

        Attachment #605737 -
        Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

        Attachment #605738 -
        Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Product: Firefox for Android → Firefox for Android Graveyard

          You need to log in
          before you can comment on or make changes to this bug.