735660 - Fix db migrations in BrowserProvider

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Lucas Rocha (:lucasr)]

Two issues:
- Migration to activate history/bookmarks view with images (with no sub-selected) was never active because the db version was not bumped.
- Migrations are simply no being committed because it's missing setTransactionSuccessful() call.

Comment 1

[Lucas Rocha (:lucasr)]

Attachment: (1/2) Commit DB transaction used by migrations

Comment 2

[Lucas Rocha (:lucasr)]

Attachment: (2/2) Bump database version to enable more performant views

Comment 3

[Lucas Rocha (:lucasr)]

Pushed:
http://hg.mozilla.org/integration/mozilla-inbound/rev/ba59b9112f6f
http://hg.mozilla.org/integration/mozilla-inbound/rev/722edd7fe3ee

Comment 4

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/ba59b9112f6f
https://hg.mozilla.org/mozilla-central/rev/722edd7fe3ee

Comment 5

[Lucas Rocha (:lucasr)]

This is a hard dependency to land bug 708149 in Aurora btw. So, this is almost automatically a beta blocker as well.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Ageed. Please ask for aurora approval.

Comment 7

[Lucas Rocha (:lucasr)]

Comment on attachment 605737 [details] [diff] [review]
(1/2) Commit DB transaction used by migrations

Mobile-only. Beta blocker.

Comment 8

[Lucas Rocha (:lucasr)]

Comment on attachment 605738 [details] [diff] [review]
(2/2) Bump database version to enable more performant views

Mobile-only. Beta blocker.

Comment 9

[Lukas Blakk [:lsblakk] use ?needinfo]

[Triage Comment]
Can we get a risk assessment here? There have been many issues lately with bookmarks (see https://wiki.mozilla.org/Firefox/Planning/2012-03-21#Desktop), will this help?

Comment 10

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Lukas Blakk [:lsblakk] from comment #9)
> [Triage Comment]
> Can we get a risk assessment here? There have been many issues lately with
> bookmarks (see
> https://wiki.mozilla.org/Firefox/Planning/2012-03-21#Desktop), will this
> help?

This change has nothing to do with Sync. This change merely makes sure the DB is updated to the newer version. The version that has a much faster awesomebar query. It is a blocker for Fennec13 too.

Comment 11

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 605737 [details] [diff] [review]
(1/2) Commit DB transaction used by migrations

[Triage Comment]
Sorry, just caught that this is a Fennec Native bug, please ignore previous comment and go ahead with this.

Comment 12

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/55ac298a9f11
https://hg.mozilla.org/releases/mozilla-aurora/rev/2c0e8e4571c8