Add Contact and Join Chat buttons should be disabled if no accounts are present

RESOLVED FIXED in Thunderbird 14.0

Status

Thunderbird
Instant Messaging
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: sid0, Assigned: florian)

Tracking

Trunk
Thunderbird 14.0

Thunderbird Tracking Flags

(thunderbird13 fixed)

Details

Attachments

(1 attachment)

If no chat accounts are present, the Add Contact and Join Chat buttons are still active. They shouldn't be.
(Assignee)

Updated

5 years ago
OS: Windows 7 → All
Hardware: x86_64 → All
Version: unspecified → Trunk
(Assignee)

Comment 1

5 years ago
Created attachment 609294 [details] [diff] [review]
Patch

Note: the status selector part of the toolbar also needs to be disabled (when there's no configured account) but it's a bit more complicated as just setting the disabled property or attribute isn't enough to obtain a satisfying behavior. Other usability issues of this status selector are covered by bug 735658 so I would rather work on this there, and do here the easy part (the Add Contact and Join Chat buttons) sooner.
Assignee: nobody → florian
Status: NEW → ASSIGNED
Attachment #609294 - Flags: review?(bwinton)
Comment on attachment 609294 [details] [diff] [review]
Patch

Seems good.  r=me.
Attachment #609294 - Flags: review?(bwinton) → review+
(Assignee)

Comment 3

5 years ago
http://hg.mozilla.org/comm-central/rev/1f63544e80ac
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 14.0
Still happens for me with windows nightly from 29-Mar-2012 07:17. Am I too early or is this not fixed?
(Assignee)

Comment 5

5 years ago
(In reply to Philipp Kewisch [:Fallen] from comment #4)
> Still happens for me with windows nightly from 29-Mar-2012 07:17. Am I too
> early or is this not fixed?

I think this may be a consequence of the error you had while creating an account (bug 740451), you probably ended up with an half created account.
(Assignee)

Comment 6

5 years ago
Comment on attachment 609294 [details] [diff] [review]
Patch

[Approval Request Comment]
Polish fix that we should take on aurora I think; not disabling these buttons when they can't be used was confusing.
Attachment #609294 - Flags: approval-comm-aurora?

Updated

5 years ago
Attachment #609294 - Flags: approval-comm-aurora? → approval-comm-aurora+
(Assignee)

Comment 7

5 years ago
http://hg.mozilla.org/releases/comm-aurora/rev/dd0fb5e15c63
status-thunderbird13: --- → fixed
You need to log in before you can comment on or make changes to this bug.