The default bug view has changed. See this FAQ.

chat - toolbar icon and tab icon are different

RESOLVED FIXED in Thunderbird 19.0

Status

Thunderbird
Theme
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: andreasn, Assigned: andreasn)

Tracking

Trunk
Thunderbird 19.0
x86_64
Linux

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(6 attachments, 4 obsolete attachments)

(Assignee)

Description

5 years ago
Created attachment 605796 [details]
screenshot

Right now we're using a different, non-os-specific icon for the chat tab icon. This should probably use a version of the toolbar icon instead.
(Assignee)

Comment 1

5 years ago
Created attachment 607189 [details] [diff] [review]
change the tab to use the same icon as in the toolbar

Only tested on Linux so far and I need to hunt down how to populate the all-tabs-popup.
(Assignee)

Updated

5 years ago
Attachment #607189 - Flags: ui-review?(mconley)
Attachment #607189 - Flags: review?(florian)
(Assignee)

Comment 2

5 years ago
Comment on attachment 607189 [details] [diff] [review]
change the tab to use the same icon as in the toolbar

Sorry, mixed this bugs tab up with another one, cancelling reviews. :)
Attachment #607189 - Flags: ui-review?(mconley)
Attachment #607189 - Flags: review?(florian)
(Assignee)

Comment 3

5 years ago
Created attachment 638396 [details] [diff] [review]
for all platforms (v2)

Unbitrotted and updated
Attachment #607189 - Attachment is obsolete: true
(Assignee)

Comment 4

5 years ago
Created attachment 638661 [details] [diff] [review]
for all platforms (v3)

When I tested this on the mac, the icon was a bit too big and fuzzy, so this gives the right dimensions (16x16) in the css.
Attachment #638396 - Attachment is obsolete: true
(Assignee)

Comment 5

5 years ago
Created attachment 638666 [details]
patch in action (win7)
(Assignee)

Comment 6

5 years ago
Created attachment 638667 [details]
patch in action (xp)
(Assignee)

Comment 7

5 years ago
Created attachment 638684 [details]
patch in action (osx)
(Assignee)

Comment 8

5 years ago
Created attachment 638685 [details]
patch in action (linux)
Comment on attachment 638661 [details] [diff] [review]
for all platforms (v3)

Not sure if you meant to request review or not, but this patch regresses the chat icon in the all tabs menu (btw, see also bug 717881 for somehow related issues with the icons in the all tabs menu).

You need .alltabs-item[type="chat"] CSS selectors, and this change to mail/base/content/tabmail.xml:

diff --git a/mail/base/content/tabmail.xml b/mail/base/content/tabmail.xml
--- a/mail/base/content/tabmail.xml
+++ b/mail/base/content/tabmail.xml
@@ -2455,16 +2455,17 @@
           var menuItem = document.createElementNS(
             "http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul", 
             "menuitem");
 
           menuItem.setAttribute("class", "menuitem-iconic alltabs-item");
 
           menuItem.setAttribute("label", aTab.label);
           menuItem.setAttribute("crop", aTab.getAttribute("crop"));
+          menuItem.setAttribute("type", aTab.getAttribute("type"));
           menuItem.setAttribute("image", aTab.getAttribute("image"));
 
           if (aTab.hasAttribute("busy"))
             menuItem.setAttribute("busy", aTab.getAttribute("busy"));
           if (aTab.selected)
             menuItem.setAttribute("selected", "true");
 
           // Keep some attributes of the menuitem in sync with its
Attachment #638661 - Flags: review-
(Assignee)

Comment 10

5 years ago
Created attachment 641036 [details] [diff] [review]
for all platforms (v4)

This patch should do the trick.
Attachment #638661 - Attachment is obsolete: true
Attachment #641036 - Flags: review?(florian)
(Assignee)

Updated

5 years ago
Attachment #641036 - Flags: ui-review?(mconley)
Comment on attachment 641036 [details] [diff] [review]
for all platforms (v4)

The code is fine with me. I haven't tested the patch, so I'm assuming the values given in -moz-image-region are right :).
Attachment #641036 - Flags: review?(florian) → review+
Comment on attachment 641036 [details] [diff] [review]
for all platforms (v4)

Sorry it took so long to get to this. This looks good.
Attachment #641036 - Flags: ui-review?(mconley) → ui-review+
Andreas did we forget this bug ?
Keywords: checkin-needed
(Assignee)

Comment 14

5 years ago
The patch don't apply cleanly on trunk so removing checkin-needed until I sort this out.
Keywords: checkin-needed
(In reply to Andreas Nilsson (:andreasn) from comment #14)
> The patch don't apply cleanly on trunk so removing checkin-needed until I
> sort this out.

Removing the changes for tabmail.xml is enough. Then the patch applies and all is working.
(Assignee)

Comment 16

4 years ago
Created attachment 682500 [details] [diff] [review]
fixes bitrot

Fixes bitrot and carrying over r+ and ui-r+
Ready for checkin
Attachment #641036 - Attachment is obsolete: true
Attachment #682500 - Flags: ui-review+
Attachment #682500 - Flags: review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/eee2bbaeaff1
Assignee: nobody → bugs
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 19.0
You need to log in before you can comment on or make changes to this bug.