add expand all button to runtests page

VERIFIED FIXED

Status

Mozilla QA
MozTrap
--
enhancement
VERIFIED FIXED
6 years ago
4 years ago

People

(Reporter: camd, Unassigned)

Tracking

Details

(Reporter)

Description

6 years ago
In contrast to the management pages, the runtest page doesn't use AJAX.  Apparently this would be mostly JavaScript.
(Reporter)

Comment 1

6 years ago
A Pivotal Tracker story has been created for this Bug: http://www.pivotaltracker.com/story/show/26443149
(Reporter)

Comment 2

6 years ago
Eric Meyer changed story state to started in Pivotal Tracker
(Reporter)

Comment 3

6 years ago
Eric Meyer added a comment in Pivotal Tracker:   
   
Jonny, besides opening all the list details, we need an "open" class added to the link itself. (this is all on the bulk-open branch)
(Reporter)

Comment 4

6 years ago
Jonny Gerig Meyer added a comment in Pivotal Tracker:   
   
Eric: The basic JS is in place. Two remaining UI questions:

1) What would you like to happen in mixed cases (where some of the tests are expanded, and others are closed)?
2) If you manually expand or collapse all tests (without using bulk-open), should bulk-open magically correspond (i.e. add/removeClass 'open')?
(Reporter)

Comment 5

6 years ago
Eric Meyer added a comment in Pivotal Tracker:   
   
1) I think all mixed cases should be considered "closed" - so clicking opens all. 
2) how hard would it be to respond to manual controls? the only case in which it is considered "open" is when all items are open.
(Reporter)

Comment 6

6 years ago
Jonny Gerig Meyer changed story state to delivered in Pivotal Tracker
(Reporter)

Comment 7

6 years ago
Cameron Dawson added a comment in Pivotal Tracker:   
   
I think the expand all button needs a tooltip.  I fear it may not be obvious to people / they may not notice it.  But we can see how that goes.  Is this a standard place to put an expand all button?
(Reporter)

Comment 8

6 years ago
Cameron Dawson changed story state to rejected in Pivotal Tracker
(Reporter)

Comment 9

6 years ago
Carl Meyer added a comment in Pivotal Tracker:   
   
Is this merged to master? Stories shouldn't be delivered until they're merged, and once they are merged we should remove the branch: tag.
(Reporter)

Comment 10

6 years ago
Carl Meyer changed story state to started in Pivotal Tracker
(Reporter)

Comment 11

6 years ago
Jonny Gerig Meyer added a comment in Pivotal Tracker:   
   
I merged it before delivering, but didn't think to remove the PT tag. Fixed.
(Reporter)

Comment 12

6 years ago
Eric Meyer added a comment in Pivotal Tracker:   
   
I added a tooltip. I also changed the icons to make them more unique, and hopefully more descriptive and noticeable.
(Reporter)

Comment 13

6 years ago
Eric Meyer changed story state to delivered in Pivotal Tracker
(Reporter)

Comment 14

6 years ago
Eric Meyer changed story state to delivered in Pivotal Tracker
(Reporter)

Comment 15

6 years ago
Cameron Dawson added a comment in Pivotal Tracker:   
   
awesome!  this looks great.  I really like the new icons, too.  More robust and easier to notice, I think.
(Reporter)

Comment 16

6 years ago
Cameron Dawson changed story state to accepted in Pivotal Tracker
(Reporter)

Updated

6 years ago
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Bumping to verified as per comment 15, shipped.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.