Report PDB name in chrome hang reports

RESOLVED FIXED in mozilla14

Status

()

Core
General
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: vladan, Assigned: vladan)

Tracking

Trunk
mozilla14
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

5 years ago
Currently, chrome hang reports report a variety of info about shared libraries loaded in memory including the shared library name, address information, and PDB Signature + PDB Age. This information is used for server-side symbolication of hang stacks. However, symbol files are stored on the server under their PDB name and not the shared library name, e.g. the XUL library symbols are stored in a directory named xul.pdb instead of xul.dll.

As it turns out, the shared library names do not always neatly map to their PDB filenames, e.g. on my machine c:\Windows\SysWOW64\ntdll.dll has a PDB named wntdll.pdb.

Therefore, chrome hang reports should also report the corresponding PDB name for shared libraries. The PDB name can be obtained from the library image, the same way as PDB signatures and PDB ages.
(Assignee)

Comment 1

5 years ago
Created attachment 606671 [details] [diff] [review]
Report PDB Name, v1
Attachment #606671 - Flags: review?(ehsan)
(Assignee)

Updated

5 years ago
Attachment #606671 - Flags: review?(ehsan) → review?(taras.mozilla)
Comment on attachment 606671 [details] [diff] [review]
Report PDB Name, v1

Review of attachment 606671 [details] [diff] [review]:
-----------------------------------------------------------------

::: tools/profiler/shared-libraries-win32.cc
@@ +50,5 @@
>  {
>    uint32_t signature;
>    GUID pdbSignature;
>    uint32_t pdbAge;
> +  char pdbFileName[1];

Make it a char* and take out the cast below.
Attachment #606671 - Flags: review?(taras.mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/102524521984
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
(Assignee)

Comment 4

5 years ago
Created attachment 609581 [details] [diff] [review]
Very minor fix: add quotes around PDB name string

Fixing small bug introduced in the first patch
(Assignee)

Comment 5

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/d69e6105b5b1
(Assignee)

Updated

5 years ago
Attachment #609581 - Flags: checkin+

Comment 6

5 years ago
https://hg.mozilla.org/mozilla-central/rev/d69e6105b5b1
You need to log in before you can comment on or make changes to this bug.