Closed
Bug 735829
Opened 12 years ago
Closed 12 years ago
Report PDB name in chrome hang reports
Categories
(Core :: General, defect)
Core
General
Tracking
()
RESOLVED
FIXED
mozilla14
People
(Reporter: vladan, Assigned: vladan)
References
Details
Attachments
(2 files)
7.13 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
1.02 KB,
patch
|
vladan
:
checkin+
|
Details | Diff | Splinter Review |
Currently, chrome hang reports report a variety of info about shared libraries loaded in memory including the shared library name, address information, and PDB Signature + PDB Age. This information is used for server-side symbolication of hang stacks. However, symbol files are stored on the server under their PDB name and not the shared library name, e.g. the XUL library symbols are stored in a directory named xul.pdb instead of xul.dll. As it turns out, the shared library names do not always neatly map to their PDB filenames, e.g. on my machine c:\Windows\SysWOW64\ntdll.dll has a PDB named wntdll.pdb. Therefore, chrome hang reports should also report the corresponding PDB name for shared libraries. The PDB name can be obtained from the library image, the same way as PDB signatures and PDB ages.
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #606671 -
Flags: review?(ehsan)
Assignee | ||
Updated•12 years ago
|
Attachment #606671 -
Flags: review?(ehsan) → review?(taras.mozilla)
Comment 2•12 years ago
|
||
Comment on attachment 606671 [details] [diff] [review] Report PDB Name, v1 Review of attachment 606671 [details] [diff] [review]: ----------------------------------------------------------------- ::: tools/profiler/shared-libraries-win32.cc @@ +50,5 @@ > { > uint32_t signature; > GUID pdbSignature; > uint32_t pdbAge; > + char pdbFileName[1]; Make it a char* and take out the cast below.
Attachment #606671 -
Flags: review?(taras.mozilla) → review+
Comment 3•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/102524521984
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
Assignee | ||
Comment 4•12 years ago
|
||
Fixing small bug introduced in the first patch
Assignee | ||
Comment 5•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/d69e6105b5b1
Assignee | ||
Updated•12 years ago
|
Attachment #609581 -
Flags: checkin+
Comment 6•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d69e6105b5b1
You need to log in
before you can comment on or make changes to this bug.
Description
•