735853 - Show compatibility error if an add-on uses nsIDocCharset

Status: RESOLVED INVALID

(addons.mozilla.org Graveyard :: Compatibility Tools, defect)

Description

[Jorge Villalobos [:jorgev] (he/him)]

As explained in bug 713825, the nsIDocCharset and nsIDocumentCharsetInfo interfaces were folded into the docshell. We need to flag all instances of nsIDocCharset.

This is a compatibility error, so the add-on should not be upgraded in this case.

Message:

This add-on uses nsIDocCharset, which was merged into the docshell component in Firefox 12. See <LINK> for more information.

Link: https://bugzilla.mozilla.org/show_bug.cgi?id=713825

Affected add-on:

https://addons.mozilla.org/en-US/firefox/addon/charset-switcher/

Comment 1

[testit]

(In reply to Jorge Villalobos [:jorgev] from comment #0)
> As explained in bug 713825, the nsIDocCharset and nsIDocumentCharsetInfo
> interfaces were folded into the docshell. We need to flag all instances of
> nsIDocCharset.
> 
> This is a compatibility error, so the add-on should not be upgraded in this
> case.

What do you mean exactly by "the add-on should not be upgraded"?

Comment 2

[Matt Basta [:basta]]

Add-ons that use those interfaces will not have their targetApplication maxVersion updated for FX12 when the add-ons are tested for compatibility.

Comment 3

[testit]

(In reply to Matt Basta from comment #2)
> Add-ons that use those interfaces will not have their targetApplication
> maxVersion updated for FX12 when the add-ons are tested for compatibility.

Thanks for the explanation. But it will be possible to change max version manually on the add-on developer hub? As far as I understand bug 713825, nsIDocCharset and nsIDocumentCharsetInfo will still be available for a while for backwards compatibility reasons.

Comment 4

[Matt Basta [:basta]]

It should be possible to do it manually. This change to the validator will just prevent these add-ons from being bumped automatically.

Comment 5

[Jorge Villalobos [:jorgev] (he/him)]

Also keep in mind that Firefox ignores maxVersion compatibility by default. The only reasons we're still doing compatibility bump is (a) AMO still shows compatibility warnings and (b) we want to notify developers if there are possible compatibility problems in their add-ons.

Comment 6

[testit]

(In reply to Jorge Villalobos [:jorgev] from comment #5)
> Also keep in mind that Firefox ignores maxVersion compatibility by default.
> The only reasons we're still doing compatibility bump is (a) AMO still shows
> compatibility warnings and (b) we want to notify developers if there are
> possible compatibility problems in their add-ons.

To be 100% sure: if I set max version manually to Firefox 12, users won't get compatability warnings on amo, right?

Concerning bug 713825: is it correct, that nsIDocCharset and nsIDocumentCharsetInfo are still available in Firefox 12? Any ideas in which Firefox version these interfaces will be removed?

Comment 7

[Jorge Villalobos [:jorgev] (he/him)]

(In reply to testit from comment #6)
> To be 100% sure: if I set max version manually to Firefox 12, users won't
> get compatability warnings on amo, right?

Right.

> Concerning bug 713825: is it correct, that nsIDocCharset and
> nsIDocumentCharsetInfo are still available in Firefox 12? Any ideas in which
> Firefox version these interfaces will be removed?

Hmm, you're right, the interfaces weren't removed, only moved to a different location. I confused that bug with many other interface merger bugs where the interfaces are nuked. In this case it looks like nothing substantial has changed.

So, we actually don't need this validation. I'll update the blog post.

Thanks!