735926 - NetUtil.asyncCopy fails to copy from a fileInputStream to a fileOutputStream

Status: RESOLVED INVALID

(Core :: Networking, defect)

Description

[David Dahl :ddahl]

While working on bug 716174 - i noticed that asyncCopy seems to fail silently when you want to copy from a fileinputstream to a fileoutputstream. We should add that support.

Comment 1

[Boris Zbarsky [:bzbarsky]]

This should be working, in general.  Where is it failing?

Comment 2

[David Dahl :ddahl]

(In reply to Boris Zbarsky (:bz) from comment #1)
> This should be working, in general.  Where is it failing?

I get a file-input-stream and create a new backup file, get the file-output-stream, and attempt NetUtil.asyncCopy:
https://bugzilla.mozilla.org/attachment.cgi?id=594329&action=diff#a/toolkit/mozapps/shared/FileUtils.jsm_sec3

It seems like there is a silent failure and the outputfile is never written to.
At one point I saw an intermittent error message, once. I will re-apply this patch and see if I see it again.

Comment 3

[Boris Zbarsky [:bzbarsky]]

A testcase actually showing the problem (e.g. when run in the error console) would be a good start...

Comment 4

[David Dahl :ddahl]

Attachment: testcase that proves me wrong

It looks like this is an INVALID bug and my problem in bug 716174 are race condition related. I would like confirmation if you have a second.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 606346 [details] [diff] [review]
testcase that proves me wrong

Seems reasonably, though:

1)  It's worth checking that ofile ended up with the right data in it.
2)  The write() call would look better like this:

  var data = "This is a test";
  fos.write(data, data.length);

Comment 6

[:Gavin Sharp [email: [e-mail]]]

So can we mark this INVALID?

Comment 7

[David Dahl :ddahl]

Sorry, forgot to mark it INVALID