Closed Bug 735987 Opened 8 years ago Closed 8 years ago

[New Tab Page] Dropping blocked links onto the grid again should unblock them

Categories

(Firefox :: General, defect)

13 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 14
Tracking Status
firefox13 --- verified

People

(Reporter: Optimizer, Assigned: ttaubert)

References

Details

Attachments

(1 file)

When you add a site manually to the New Tab Page, you cannot remove it by clicking on the cross button on upper right corner unless you unpin it.
And if you unpin it after clicking on the cross atleast once, then it automatically gets removed on unpinning.
PS: This behavior is visible only after the New layout for NTP landed.
Blocks: 729878, 455553
This happens randomly.
The STR are very complex for this bug, 
1) All the other tabs should be pinned (either manually added or pinning the already existing thumbnails)
2) This only happens to the thumbnails added manually
3) This does not start happening untill all the tiles are filled and pinned.
4) But once the above condition is satisfied, this will happen untill you close the page, even if you remove the already existing sites.

Still there might be some other STR also. This is random at times.
Assignee: nobody → ttaubert
Summary: Manually pinned Sites on NTP does not get removed on clicking the cross button. → Dropping blocked links onto the grid again should unblock them
Summary: Dropping blocked links onto the grid again should unblock them → [New Tab Page] Dropping blocked links onto the grid again should unblock them
Attached patch patch v1Splinter Review
Unblocks a link before pinning it on the grid when accepting an external drop.
Attachment #606141 - Flags: review?(dietrich)
Attachment #606141 - Flags: review?(dietrich) → review+
https://hg.mozilla.org/integration/fx-team/rev/34a7a331811f
Status: NEW → ASSIGNED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 14
https://hg.mozilla.org/mozilla-central/rev/34a7a331811f
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Comment on attachment 606141 [details] [diff] [review]
patch v1

[Approval Request Comment]
Regression caused by (bug #): new newtab layout
User impact if declined: weird behavior, removing a site not working
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky): small patch with test
String changes made by this patch: none
Attachment #606141 - Flags: approval-mozilla-aurora?
Comment on attachment 606141 [details] [diff] [review]
patch v1

[Triage Comment]
Low risk patch in support of correctness in a new feature. Approved for Aurora 13.
Attachment #606141 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Mozilla/5.0 (X11; Linux i686; rv:13.0) Gecko/20120424 Firefox/13.0a2

Verified on Mac OS 10.6, Ubuntu 11.10 and Windows 7.

1. Manually add a site to the new tab page.
2. Close the new tab page.
3. Open the new tab page.
4. remove the site added in step 1. 

The site can now be removed.
Depends on: 767693
See Also: → 1458658
You need to log in before you can comment on or make changes to this bug.