Closed Bug 736036 Opened 9 years ago Closed 5 years ago

Intermittent TEST-UNEXPECTED-FAIL | browser_tabview_bug610242.js | png has no favicon - Got block, expected none

Categories

(Firefox Graveyard :: Panorama, defect)

defect
Not set
normal

Tracking

(firefox27 disabled, firefox28 disabled, firefox29 disabled)

RESOLVED WONTFIX
Tracking Status
firefox27 --- disabled
firefox28 --- disabled
firefox29 --- disabled

People

(Reporter: ttaubert, Unassigned)

References

Details

(Keywords: intermittent-failure, Whiteboard: [test disabled][leave open])

Attachments

(1 file)

Ok, I think that's my fault. I didn't recognize that Ramyond was using afterAllTabItemsUpdated() which of course ensures that all favicons will get updated m(

I reverted the change from bug 678374 comment #49 and pushed it to try.
Assignee: nobody → ttaubert
Status: NEW → ASSIGNED
Attached patch patch v1Splinter Review
This fixes the intermittent orange. Not a single occurrence in the try run:

https://tbpl.mozilla.org/?tree=Try&rev=cdae0d0420a2
Attachment #606253 - Flags: review?(dietrich)
Attachment #606253 - Flags: review?(dietrich) → review+
https://hg.mozilla.org/integration/fx-team/rev/f24062a2aebb
Whiteboard: [orange] → [orange][fixed-in-fx-team]
Target Milestone: --- → Firefox 14
https://hg.mozilla.org/mozilla-central/rev/f24062a2aebb
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [orange][fixed-in-fx-team] → [orange]
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Whiteboard: [orange]
Please can you find an owner for this intermittent-failure - the current overall tree intermittent failure rate is spiralling out of control & the majority of bugs are unowned (see dev.platform thread).
Flags: needinfo?(ttaubert)
I'm not sure I can justify spending any time on figuring this out. I'd suggest we disable the test if it keeps failing while we continue to prepare removing Panorama.
Flags: needinfo?(ttaubert)
(In reply to Tim Taubert [:ttaubert] from comment #37)
> I'm not sure I can justify spending any time on figuring this out. I'd
> suggest we disable the test if it keeps failing while we continue to prepare
> removing Panorama.

Cool, makes sense to me :-)

Disabled this test and a few other tabview intermittents:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cf4112d50b68
Status: REOPENED → RESOLVED
Closed: 9 years ago8 years ago
Resolution: --- → WONTFIX
Whiteboard: [test disabled]
And then it got reenabled.
Status: RESOLVED → REOPENED
Depends on: 791284
Resolution: WONTFIX → ---
Whiteboard: [test disabled]
Target Milestone: Firefox 14 → ---
Assignee: ttaubert → nobody
Panorama has been removed from Firefox 45, currently in Beta and scheduled for release on March 7th. As such, I'm closing all existing Panorama bugs.

If you are still using Panorama, you will see a deprecation message in Firefox 44, and when 45 is released your tab group data will be migrated to bookmarks, with a folder for each group. There are also a few addons offering similar functionality.

See https://support.mozilla.org/en-US/kb/tab-groups-removal for more info.

We're removing Panorama because it has extremely low usage (about 0.01% of users), and has a large number of bugs and usability issues. The cost of fixing all those issues is far too high to justify, and so we'll instead be focusing our time and energy on improving other parts of Firefox.
Status: REOPENED → RESOLVED
Closed: 8 years ago5 years ago
Resolution: --- → WONTFIX
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.