Closed Bug 736040 Opened 12 years ago Closed 12 years ago

When disabling Filelink, the "Convert To" attachmentitem context menuitem should be hidden

Categories

(Thunderbird :: Message Compose Window, defect)

Product:
Thunderbird
Component:
Message Compose Window
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(thunderbird13 fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 14.0
Tracking Flags:
Tracking Status
thunderbird13 --- fixed

People

(Reporter: standard8, Assigned: mconley)

References

Details

(Whiteboard: [esr])

Attachments

(1 file, 1 obsolete file)

Patch v2
3.11 KB, patch
squib
: review+
standard8
: approval-comm-aurora+
Details | Diff | Splinter Review 
Organisations are likely going to be disabling Filelink for their own reasons. Users may choose to as well.

I think that if they do, then we should disable the whole of the preferences window. This makes it clear it is fully disabled.

At the moment, if I lock the preference to disable it, only the check box is disabled.
I just noticed, the right-click menu in the attachments dialog isn't hidden either.
Summary: When disabling Filelink in the preferences dialog, the preferences UI for accounts should also be disabled → When disabling Filelink in the preferences dialog, the preferences UI for accounts and for "Convert To" should also be disabled
Mark:

Hm - setting mail.cloud_file.enabled to false hides the "Outgoing" tab in the Attachments pane for me completely.  Can you give me STR?

Yes, the "Convert To" menuitem is still visible.  I'll draw up a patch.  Good catch!

-Mike
Assignee: nobody → mconley
Blocks: BigFiles
Summary: When disabling Filelink in the preferences dialog, the preferences UI for accounts and for "Convert To" should also be disabled → When disabling Filelink, the "Convert To" attachmentitem context menuitem should be hidden
Comment on attachment 606245 [details] [diff] [review]
Hide "Convert To" menuitem, "Cancel Upload" menuitem

This seems to do the job.
Attachment #606245 - Flags: review?(squibblyflabbetydoo)
Attached patch Patch v2 — — Splinter Review 
Thanks for the review over IRC - made the suggested fixes.
Attachment #606245 - Attachment is obsolete: true
Attachment #606245 - Flags: review?(squibblyflabbetydoo)
Attachment #606284 - Flags: review?(squibblyflabbetydoo)
Comment on attachment 606284 [details] [diff] [review]
Patch v2

Review of attachment 606284 [details] [diff] [review]:
-----------------------------------------------------------------

I tested this out, and it looks good to me.
Attachment #606284 - Flags: review?(squibblyflabbetydoo) → review+
Attachment #606284 - Flags: approval-comm-aurora?
Committed to comm-central as http://hg.mozilla.org/comm-central/rev/94d6e21b9ed3
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 14.0
Attachment #606284 - Flags: approval-comm-aurora? → approval-comm-aurora+
tracking-thunderbird13: ? → ---
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: