When disabling Filelink, the "Convert To" attachmentitem context menuitem should be hidden

RESOLVED FIXED in Thunderbird 14.0

Status

Thunderbird
Message Compose Window
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: standard8, Assigned: mconley)

Tracking

Trunk
Thunderbird 14.0

Thunderbird Tracking Flags

(thunderbird13 fixed)

Details

(Whiteboard: [esr])

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

5 years ago
Organisations are likely going to be disabling Filelink for their own reasons. Users may choose to as well.

I think that if they do, then we should disable the whole of the preferences window. This makes it clear it is fully disabled.

At the moment, if I lock the preference to disable it, only the check box is disabled.
(Reporter)

Comment 1

5 years ago
I just noticed, the right-click menu in the attachments dialog isn't hidden either.
Summary: When disabling Filelink in the preferences dialog, the preferences UI for accounts should also be disabled → When disabling Filelink in the preferences dialog, the preferences UI for accounts and for "Convert To" should also be disabled
(Assignee)

Comment 2

5 years ago
Mark:

Hm - setting mail.cloud_file.enabled to false hides the "Outgoing" tab in the Attachments pane for me completely.  Can you give me STR?

Yes, the "Convert To" menuitem is still visible.  I'll draw up a patch.  Good catch!

-Mike
Assignee: nobody → mconley
(Assignee)

Updated

5 years ago
Blocks: 698925
(Assignee)

Updated

5 years ago
Summary: When disabling Filelink in the preferences dialog, the preferences UI for accounts and for "Convert To" should also be disabled → When disabling Filelink, the "Convert To" attachmentitem context menuitem should be hidden
(Assignee)

Comment 3

5 years ago
Created attachment 606245 [details] [diff] [review]
Hide "Convert To" menuitem, "Cancel Upload" menuitem
(Assignee)

Updated

5 years ago
tracking-thunderbird13: --- → ?
(Assignee)

Comment 4

5 years ago
Comment on attachment 606245 [details] [diff] [review]
Hide "Convert To" menuitem, "Cancel Upload" menuitem

This seems to do the job.
Attachment #606245 - Flags: review?(squibblyflabbetydoo)
(Assignee)

Comment 5

5 years ago
Created attachment 606284 [details] [diff] [review]
Patch v2

Thanks for the review over IRC - made the suggested fixes.
Attachment #606245 - Attachment is obsolete: true
Attachment #606245 - Flags: review?(squibblyflabbetydoo)
Attachment #606284 - Flags: review?(squibblyflabbetydoo)

Comment 6

5 years ago
Comment on attachment 606284 [details] [diff] [review]
Patch v2

Review of attachment 606284 [details] [diff] [review]:
-----------------------------------------------------------------

I tested this out, and it looks good to me.
Attachment #606284 - Flags: review?(squibblyflabbetydoo) → review+
(Assignee)

Updated

5 years ago
Attachment #606284 - Flags: approval-comm-aurora?
(Assignee)

Comment 7

5 years ago
Committed to comm-central as http://hg.mozilla.org/comm-central/rev/94d6e21b9ed3
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 14.0
(Reporter)

Updated

5 years ago
Attachment #606284 - Flags: approval-comm-aurora? → approval-comm-aurora+
(Assignee)

Comment 8

5 years ago
Committed to comm-aurora as http://hg.mozilla.org/releases/comm-aurora/rev/b12304800316
status-thunderbird13: --- → fixed
(Reporter)

Updated

5 years ago
tracking-thunderbird13: ? → ---
You need to log in before you can comment on or make changes to this bug.