Note: There are a few cases of duplicates in user autocompletion which are being worked on.

do some cleanups of nsAccessible::GetAttributesInternal

RESOLVED FIXED in mozilla14

Status

()

Core
Disability Access APIs
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: surkov, Assigned: surkov)

Tracking

(Blocks: 1 bug)

unspecified
mozilla14
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: access)

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 606189 [details] [diff] [review]
patch

follow up from bug 729831

1) add mochitest for bug 729831 case
2) don't expose object attributes for non primary node accessibles
Attachment #606189 - Flags: review?(trev.saunders)
(Assignee)

Comment 1

5 years ago
Trevor, ping
Comment on attachment 606189 [details] [diff] [review]
patch

> nsAccessible::GetAttributesInternal(nsIPersistentProperties *aAttributes)
> {
>+  // Don't calculate content based object attributes for not primary for the
>+  // DOM node accessible (like list bullet or XUL tree items).

if the accessible isn't primary for its node (such as list item bullet or xul tree item then don't clculate  content based attributes

>   // Don't calculate CSS-based object attributes when no frame (i.e.
>-  // the accessible is not unattached form three) or when the accessible is not
>-  // primary for node (like list bullet or XUL tree items).
>-  if (!mContent->GetPrimaryFrame() || !IsPrimaryForNode())
>+  // the accessible is unattached from the three).

typo
Attachment #606189 - Flags: review?(trev.saunders) → review+
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/9726ff9a8868
trevor's nits: https://hg.mozilla.org/integration/mozilla-inbound/rev/a76abef16726
https://hg.mozilla.org/mozilla-central/rev/9726ff9a8868
https://hg.mozilla.org/mozilla-central/rev/a76abef16726
Assignee: nobody → surkov.alexander
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
(Assignee)

Updated

5 years ago
Flags: in-testsuite+
You need to log in before you can comment on or make changes to this bug.