Last Comment Bug 736059 - do some cleanups of nsAccessible::GetAttributesInternal
: do some cleanups of nsAccessible::GetAttributesInternal
Status: RESOLVED FIXED
access
:
Product: Core
Classification: Components
Component: Disability Access APIs (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla14
Assigned To: alexander :surkov
:
Mentors:
Depends on:
Blocks: cleana11y
  Show dependency treegraph
 
Reported: 2012-03-15 06:56 PDT by alexander :surkov
Modified: 2012-03-26 20:02 PDT (History)
2 users (show)
surkov.alexander: in‑testsuite+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (8.93 KB, patch)
2012-03-15 06:56 PDT, alexander :surkov
tbsaunde+mozbugs: review+
Details | Diff | Splinter Review

Description alexander :surkov 2012-03-15 06:56:34 PDT
Created attachment 606189 [details] [diff] [review]
patch

follow up from bug 729831

1) add mochitest for bug 729831 case
2) don't expose object attributes for non primary node accessibles
Comment 1 alexander :surkov 2012-03-23 19:12:02 PDT
Trevor, ping
Comment 2 Trevor Saunders (:tbsaunde) 2012-03-23 19:28:51 PDT
Comment on attachment 606189 [details] [diff] [review]
patch

> nsAccessible::GetAttributesInternal(nsIPersistentProperties *aAttributes)
> {
>+  // Don't calculate content based object attributes for not primary for the
>+  // DOM node accessible (like list bullet or XUL tree items).

if the accessible isn't primary for its node (such as list item bullet or xul tree item then don't clculate  content based attributes

>   // Don't calculate CSS-based object attributes when no frame (i.e.
>-  // the accessible is not unattached form three) or when the accessible is not
>-  // primary for node (like list bullet or XUL tree items).
>-  if (!mContent->GetPrimaryFrame() || !IsPrimaryForNode())
>+  // the accessible is unattached from the three).

typo

Note You need to log in before you can comment on or make changes to this bug.