Closed Bug 736059 Opened 9 years ago Closed 9 years ago

do some cleanups of nsAccessible::GetAttributesInternal

Categories

(Core :: Disability Access APIs, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla14

People

(Reporter: surkov, Assigned: surkov)

References

(Blocks 1 open bug)

Details

(Whiteboard: access)

Attachments

(1 file)

Attached patch patchSplinter Review
follow up from bug 729831

1) add mochitest for bug 729831 case
2) don't expose object attributes for non primary node accessibles
Attachment #606189 - Flags: review?(trev.saunders)
Trevor, ping
Comment on attachment 606189 [details] [diff] [review]
patch

> nsAccessible::GetAttributesInternal(nsIPersistentProperties *aAttributes)
> {
>+  // Don't calculate content based object attributes for not primary for the
>+  // DOM node accessible (like list bullet or XUL tree items).

if the accessible isn't primary for its node (such as list item bullet or xul tree item then don't clculate  content based attributes

>   // Don't calculate CSS-based object attributes when no frame (i.e.
>-  // the accessible is not unattached form three) or when the accessible is not
>-  // primary for node (like list bullet or XUL tree items).
>-  if (!mContent->GetPrimaryFrame() || !IsPrimaryForNode())
>+  // the accessible is unattached from the three).

typo
Attachment #606189 - Flags: review?(trev.saunders) → review+
https://hg.mozilla.org/mozilla-central/rev/9726ff9a8868
https://hg.mozilla.org/mozilla-central/rev/a76abef16726
Assignee: nobody → surkov.alexander
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
Flags: in-testsuite+
You need to log in before you can comment on or make changes to this bug.