If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Auto-detect platform in MozillaScraper

RESOLVED FIXED

Status

Mozilla QA Graveyard
Mozmill Automation
RESOLVED FIXED
6 years ago
3 years ago

People

(Reporter: whimboo, Assigned: whimboo)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Right now it is necessary to specify the platform option for the download script. We should make this optional so that the scraper itself can figure out what the current platform is.
(Assignee)

Updated

6 years ago
Depends on: 528064
(Assignee)

Updated

6 years ago
Blocks: 718660

Comment 1

6 years ago
mozinfo exists for this purpose: https://github.com/mozilla/mozbase/tree/master/mozinfo

If there are parameters missing from mozinfo that are needed here it could be extended.
(Assignee)

Comment 2

6 years ago
Created attachment 606259 [details] [diff] [review]
Patch v1

This patch grabs a copy of the mozinfo module which is available starting with Mozmill 2.0. So we can easily exchange it later.
Attachment #606259 - Flags: review?(dave.hunt)
Comment on attachment 606259 [details] [diff] [review]
Patch v1

Is there any way of having mozinfo as a dependency rather than committing it? Other than that I think this is a great enchancement. r+
Attachment #606259 - Flags: review?(dave.hunt) → review+
(Assignee)

Comment 4

6 years ago
No, not yet. But once we flipped to Mozmill 2 it will be automatically installed and available. Means we simply would have to remove the module from our own code base.

Landed as:
http://hg.mozilla.org/qa/mozmill-automation/rev/d06cd12bd37f
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in before you can comment on or make changes to this bug.