73612 - Current PATH setting loads the wrong zlib.dll == crash

Status: RESOLVED WONTFIX

(Core Graveyard :: Embedding: ActiveX Wrapper, defect)

Description

[mozilla]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Win98; en-US; 0.8.1) Gecko/20010320
BuildID:    2001032004

i use the topstyle 2 program to create css files
this program can use mozilla as it's internal browser 
i registered mozctlx.dll with regsvr32 mozctlx.dll
but when i try to use the preview function with mozilla i get an error
of an access violation in zlib.dll 

when looking for zlib.dll i can find a zlib.dll in both my mozilla dir and in
windows sytem, my idea is that mozilla is picking the wrong zlib
details about zlib in sytem : 
version : 1.1.2
description : zlib data compression library
copyright : (C) 1995-1998 Jean-loup Gailly & Mark Adle

i also have the same problem with coldfusion studio 4.5




Reproducible: Always
Steps to Reproduce:
1.register mozctlx.dll
2.startup topsytle 2 pro and let it use mozilla as it's internal browser
3.do a preview and see it crash in zlib.dll

i guess that these 2 program's are not the only ones where the control has
problems when there is another zlib.dll present

Comment 1

[timeless]

erm. so this is a path problem. i'm assuming it's our fault and not nspr..

Comment 2

[Adam Lock]

Try a recent nightly. I've changed the PATH manipulation code so that the 
Mozilla path goes *before* any others. This should guarantee the search order 
will start with the Moz bin directory.

Comment 3

[mozilla]

did the test again with 2001032804 same crash
and it's indeed the zlib.dll when i rename the zlib.dll the embedding does work

i did however experience a lot of lockup's when testing the embedding when i
used a talkback enabled build then i got first an error message from toptstyle
that something was wrong with gecko and then a crash in fullsoft.dll

when i used a non-talkback build i got a crash in zlib.dll

tested under both win98 & winnt 4 on 2 pc's

Comment 4

[Keyser Sose]

Reporter do you have the talkback id of the crash?

Comment 5

[mozilla]

no talkback id
i alway get a crash in fullsoft dll with a talback enabled build and the agent 
doesn't pop-up but my system always is completly broken after a crash in this 
one and only a reboot fixes things

Comment 6

[Adam Lock]

It's possible that Win98 always searches through the windows & system 
directories before any others, whether you want it to or not.

If this is the case then I don't think there is much that I can do to prevent 
this from happening. I know that the control ensures that the Moz bin path is 
the first in the PATH environment variable so if there is more than one it 
*should* pick up the correct one first. The line that does the fixup is here:

http://lxr.mozilla.org/seamonkey/source/embedding/browser/activex/src/control_ki﷒0﷓

Do you know what software may be putting zlib.dll into your system dir?

Comment 7

[mozilla]

if i new which one, i would be happy that way i would know if i could throw it 
out the door

i'm still looking after a program to scan through my system to find out which 
program uses this dll but no luck until now

Comment 8

[mozilla]

the problem also exists in nt4
tested with topstyle, homestudio & http://www.iol.ie/~locka/mozilla/mozctltest1.htm

i hate to suggest something like this but changing zlib.dll to nszlib.dll isn't
that a sollution?

Comment 9

[mozilla]

well i found it and it's a fun one
it's icq so this is going to pop-up alot

the version of icq i have is 99b beta v.3.19 buikd #2569

i found it by sniffing in the applog directory from windows and watching a bit
with filemon from sysinternal's i think i can safely move the zlib dll to the
icq dir since it does a seek there but since it's icq it will show again

Comment 10

[mozilla]

i found a simpler sollution
the path setting is actualy working but just not good enough
here is a log from filemon:
20:57:44
TopStyle2.exe:1388
IRP_MJ_CREATE
D:\program files\Bradbury\TopStyle2\zlib.dll	FILE NOT FOUND	Attributes: Any Options: Open 	
20:57:44
TopStyle2.exe:1388
IRP_MJ_CREATE
D:\program files\Bradbury\TopStyle2\user\templates\\zlib.dll	FILE NOT FOUND	Attributes: Any Options: Open 	
20:57:44
TopStyle2.exe:1388
IRP_MJ_CREATE
E:\WINNT\System32\zlib.dll
FILE NOT FOUND	Attributes: Any Options: Open 	
20:57:44
TopStyle2.exe:1388
IRP_MJ_CREATE
E:\WINNT\system\zlib.dll
FILE NOT FOUND	Attributes: Any Options: Open 	
20:57:44
TopStyle2.exe:1388
IRP_MJ_CREATE
E:\WINNT\zlib.dll
FILE NOT FOUND	Attributes: Any Options: Open 	
20:57:44
TopStyle2.exe:1388
IRP_MJ_CREATE
J:\MOZILL~2\bin\zlib.dll
SUCCESS
Attributes: Any Options: Open 	
20:57:44
TopStyle2.exe:1388
FASTIO_QUERY_BASIC_INFO
J:\MOZILL~2\bin\zlib.dll
SUCCESS
Attributes: A	
20:57:44
TopStyle2.exe:1388
IRP_MJ_CLEANUP
J:\MOZILL~2\bin\zlib.dll
SUCCESS
	
20:57:44
TopStyle2.exe:1388
IRP_MJ_CLOSE 	J:\MOZILL~2\bin\zlib.dll	SUCCESS		
20:57:44
TopStyle2.exe:1388
IRP_MJ_CREATE
J:\MOZILL~2\bin\zlib.dll
SUCCESS
Attributes: Any Options: Open 	
20:57:44
TopStyle2.exe:1388
IRP_MJ_CLEANUP
J:\MOZILL~2\bin\zlib.dll
SUCCESS
	
20:57:44
TopStyle2.exe:1388
IRP_MJ_CLOSE 	J:\MOZILL~2\bin\zlib.dll	SUCCESS		


so as you see it goes after zlib.dll in the place it's supposed to be in the
local directory where the embedding app is placed however mozilla is not place
together with this app
so if you set the path to <path_of_embedding_app>;<path_of_mozilla>;<path>
everything should work
as far as i can see in the source for the kicker you have the path of mozilla so
it should be easy to fix

how you something with this

Comment 11

[mozilla]

hmm last line is a bit wrong
should have been hope you can do something with it

Comment 12

[Adam Lock]

Retargetting.

As far as I am aware control_kicker should and does place the Moz bin directory 
before all others. This should mean its zlib.dll is the one that gets picked up. 
Yes, the DLL could be renamed but it sounds more like this is a broken 
installation. I would be interested to know if more recent versions of icq 
stuff DLLs into a public area, given how antisocial such behaviour is.

Comment 13

[mozilla]

i haven't installed a new version yet but after talking to a few people it seems 
that also with 2000 you get a zlib.dll version 

i will try to get a decent install log this week

anyway i got the control working now with moving the zlib to the icq dir
but i guess other people might run into this

it's still strange that the path is not correctly set
do you have any pointer to any possible small app to test with?
to be sure that the problem is related to the embedding app or the control

Comment 14

[Adam Lock]

I'm not sure why this has been marked critical...

I am positive that the Mozilla bin PATH is put before all others. Unless the 
host app or some other DLL/control is tampering with it it should work as 
intended. If you wish to verify with another application, try opening this link 
in IE:

http://www.iol.ie/~locka/mozilla/mozctltest1.htm

Also, I installed ICQ 2000b and it doesn't appear to put zlib.dll into the 
Windows directory, not on Windows 2000 at least. On older versions of ICQ, 
try moving the zlib.dll to the ICQ directory.

I really don't think this a problem with the control.

Comment 15

[Adam Lock]

Changing summary

Comment 16

[Keyser Sose]

Marking NEW while this is figured out.

Comment 17

[Adam Lock]

I am going to mark this WONTFIX.

The control is putting the Moz bin path at the front of all others so there is 
little else that can be done to fix this problem. 

Comment 18

[Adam Lock]

Hi,

You might like to know that the issue of multiple zlib dlls has cropped up again
in bug 86323 with someone submitting a patch, so it looks like it may be sorted
out. FYI I installed the latest version of ICQ recently and their zlib.dll was
installed into the ICQ directory.