Closed Bug 736260 Opened 8 years ago Closed 7 years ago

update google-jp.xml search plugins to use https

Categories

(Mozilla Localizations :: ja / Japanese, enhancement)

enhancement
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla14

People

(Reporter: geekboy, Assigned: marsf)

References

Details

(Keywords: jp-critical, productization)

Attachments

(3 files, 2 obsolete files)

In line with bug 633773, we should update all of the the google-jp.xml search plugins to use HTTPS endpoints instead of HTTP.  This includes at least:

/ja-JP-mac/mail/searchplugins/google-jp.xml
/ja-JP-mac/suite/searchplugins/google-jp.xml
/ja-JP-mac/browser/searchplugins/google-jp.xml
/ja/mail/searchplugins/google-jp.xml
/ja/suite/searchplugins/google-jp.xml
/ja/browser/searchplugins/google-jp.xml
Keywords: productization
OS: Linux → All
Hardware: x86 → All
Target Milestone: --- → mozilla14
Severity: normal → enhancement
Assignee: nobody → chimantaea_mirabilis
Status: NEW → ASSIGNED
Bug 731080
Blocks: 731080
Bug 731080 must be fixed first.

# I missed comment 1, please ignore it.
Attached patch use https (obsolete) — Splinter Review
/ja/browser/chrome/browser-region/region.properties
/ja/browser/searchplugins/google-jp.xml
/ja/mail/chrome/messenger-region/region.properties
/ja/mail/searchplugins/google-jp.xml
/ja/mobile/chrome/region.properties
/ja/mobile/searchplugins/google-jp.xml
/ja/suite/chrome/browser/region.properties
/ja/suite/chrome/mailnews/region.properties
/ja/suite/searchplugins/google-jp.xml
ja-JP-mac is same with them.
Oh, for mobile has already fixed on Bug 753231.
Attached patch use https (ja)Splinter Review
patch again, without /mobile.
Attachment #622941 - Attachment is obsolete: true
Attachment #627409 - Flags: review?(l10n)
same with ja.
Attachment #627411 - Flags: review?(l10n)
Comment on attachment 627409 [details] [diff] [review]
use https (ja)

Review of attachment 627409 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry, I'll r- these, for no better reason as that I don't know if we're actually cool to switch all those services over.

Please only change browser search now with review requests on me. If the mail ones are fine should be a separate patch for Standard8.
Attachment #627409 - Flags: review?(l10n) → review-
Attachment #627411 - Flags: review?(l10n) → review-
Attached patch patch for browser (ja/ja-JP-mac) (obsolete) — Splinter Review
Ok, I've separated the patch.
The patch for "ja" and "ja-JP-mac" are completely same.
Attachment #627489 - Flags: review?(l10n)
Comment on attachment 627489 [details] [diff] [review]
patch for browser (ja/ja-JP-mac)

Review of attachment 627489 [details] [diff] [review]:
-----------------------------------------------------------------

r- for the content handlers.

::: browser/chrome/browser-region/region.properties
@@ +18,5 @@
>  
>  # This is the default set of web based feed handlers shown in the reader
>  # selection UI
>  browser.contentHandlers.types.0.title	= Google リーダー
> +browser.contentHandlers.types.0.uri	= https://www.google.com/reader/view/feed/%s

Please don't change this, I'm not sure it's OK for us to hit this service on https. In en-US, we're still using fusion.google.com via http, so it's hard to tell if we got permission for this or not.
Attachment #627489 - Flags: review?(l10n) → review-
(In reply to Axel Hecht [:Pike] from comment #10)
> Please don't change this, I'm not sure it's OK for us to hit this service on
> https. In en-US, we're still using fusion.google.com via http, so it's hard
> to tell if we got permission for this or not.

I cannot decide it.
Yoshino-san, can we change Google reader to use https, or should I make a patch for "google-jp.xml" only?
I cannot decide it either. Technically there should be no problem here but the purpose of this change is protecting user privacy on Google Search. So I feel we should only change search-related URLs at this time. We can change other stuff later if needed.
Now, removed the change of "browser.contentHandlers.types.0.uri" from previous patch.
Attachment #627489 - Attachment is obsolete: true
Comment on attachment 627832 [details] [diff] [review]
patch for browser, v2

Review of attachment 627832 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, thanks for hanging in on this.

Please land this with a check-in comment referencing this bug and my review, as usual.
Attachment #627832 - Flags: review+
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.