736279 - Followup to fix bugs in about:home Visual Refresh

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Frank Yan (:fryn)]

Attachment: patch

There are three issues with about:home that we should fix immediately:
1. Launcher buttons do not crop properly when the restore session button is not present. (CSS flexbox weirdness)
2. The restore session button doesn't disappear after the session has been restored. (Typo!)
3. The about:home onload handler in browser.js throws when the document is being unloaded as it gets executed. This was an issue before the new about:home stuff landed, but it's a one-line fix, so I'll do it here.

Comment 1

[Frank Yan (:fryn)]

Attachment: patch v2

Also added "Marketplace" to aboutHome.dtd to avoid fuss later.

Comment 2

[Frank Yan (:fryn)]

Attachment: patch v3

Third time's the charm (I hope)!
(This is what happens when I try to write code on 3 hours of sleep.)

Comment 3

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

https://hg.mozilla.org/mozilla-central/rev/6987476adb87

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

and backported to aurora with bug 711157

Comment 5

[Ioana (away)]

Mozilla/5.0 (Windows NT 6.1; rv:13.0) Gecko/20100101 Firefox/13.0
BuildID: 20120528154913

I have verified point 2 from comment 0. The Restore Session button disappeared after restoring the session.

Frank, can you please tell me:
 what I should/shouldn't see when verifying point 1?
 how can I verify point 3?

Comment 6

[Frank Yan (:fryn)]

(In reply to Ioana Budnar [QA] from comment #5)

This doesn't need further verification.
Feel free to move onto other bugs.
Thanks.