Followup to fix bugs in about:home Visual Refresh

RESOLVED FIXED in Firefox 13

Status

()

Firefox
General
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: fryn, Assigned: fryn)

Tracking

Trunk
Firefox 14
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox13 fixed)

Details

(Whiteboard: [qa-], URL)

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

5 years ago
Created attachment 606362 [details] [diff] [review]
patch

There are three issues with about:home that we should fix immediately:
1. Launcher buttons do not crop properly when the restore session button is not present. (CSS flexbox weirdness)
2. The restore session button doesn't disappear after the session has been restored. (Typo!)
3. The about:home onload handler in browser.js throws when the document is being unloaded as it gets executed. This was an issue before the new about:home stuff landed, but it's a one-line fix, so I'll do it here.
Attachment #606362 - Flags: review?(mak77)
(Assignee)

Comment 1

5 years ago
Created attachment 606374 [details] [diff] [review]
patch v2

Also added "Marketplace" to aboutHome.dtd to avoid fuss later.
Attachment #606362 - Attachment is obsolete: true
Attachment #606362 - Flags: review?(mak77)
Attachment #606374 - Flags: review?(mak77)
(Assignee)

Comment 2

5 years ago
Created attachment 606378 [details] [diff] [review]
patch v3

Third time's the charm (I hope)!
(This is what happens when I try to write code on 3 hours of sleep.)
Attachment #606374 - Attachment is obsolete: true
Attachment #606374 - Flags: review?(mak77)
Attachment #606378 - Flags: review?(mak77)

Updated

5 years ago
Attachment #606378 - Flags: review?(mak77) → review+
https://hg.mozilla.org/mozilla-central/rev/6987476adb87
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 14
and backported to aurora with bug 711157
status-firefox13: --- → fixed
(Assignee)

Updated

5 years ago
Depends on: 736512
(Assignee)

Updated

5 years ago
Target Milestone: Firefox 14 → Firefox 13
(Assignee)

Updated

5 years ago
Target Milestone: Firefox 13 → Firefox 14
Whiteboard: [qa+]

Comment 5

5 years ago
Mozilla/5.0 (Windows NT 6.1; rv:13.0) Gecko/20100101 Firefox/13.0
BuildID: 20120528154913

I have verified point 2 from comment 0. The Restore Session button disappeared after restoring the session.

Frank, can you please tell me:
 what I should/shouldn't see when verifying point 1?
 how can I verify point 3?
(Assignee)

Comment 6

5 years ago
(In reply to Ioana Budnar [QA] from comment #5)

This doesn't need further verification.
Feel free to move onto other bugs.
Thanks.
Whiteboard: [qa+] → [qa-]
You need to log in before you can comment on or make changes to this bug.