736309 - IntegrityError: Duplicate entry for key 'email' in browser ID signup

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P2)

Description

[Kumar McMillan [:kumar]]

This is similar to bug 731639 but different in that a Django user with the same email existed when the user tried to register with browser ID.

https://arecibo-phx.mozilla.org/view/1741948/

Comment 1

[Kumar McMillan [:kumar]]

Hi John. Sorry! We are close to solving your registration problem. We solved the last bug but now we're hitting something new. It's tricky because none of us were able to reproduce it.

Comment 2

[Allen Short [:ashort]]

After discussing with kumar we're reaching the conclusion that fixing the bad data in the db that's resulted from lack of transactional updates is probably a better choice than writing workarounds for it. The specific problem in this case is that a row exists in `auth_user` for this email but the `user_userprofile` row doesn't refer to it (or any other); when zamboni tries to create a new `auth_user` the conflict occurs.

Comment 3

[Allen Short [:ashort]]

Further investigation indicates there's a few different failure modes occurring. Here's a handy table to keep track of what can happen depending on DB state and whether browserid is in use:

>|                     | BrowserID                                         | Password                   |
>|---------------------+---------------------------------------------------+----------------------------|
>| Both exist unlinked | 'NoneType' has no attribute 'backend'             | Link created on login      |
>| no auth_user        | 'NoneType' has no attribute 'backend'             | auth_user created on login |
>| no user             | Duplicate entry '[e-mail]' for key 'email' | login failure no traceback |

Comment 4

[Allen Short [:ashort]]

https://github.com/mozilla/zamboni/commit/1e0d64fd8d04006b2c410a122ee88de272929b64