736346 - Bump Venkman compatibility for Firefox 14.0 / SeaMonkey 2.11 / Thunderbird 14.0 / (Gecko) Toolkit 14.0

Status: VERIFIED FIXED

(Other Applications Graveyard :: Venkman JS Debugger, defect, P2)

Description

[Serge Gautherie (:sgautherie)]

+++ This bug was initially created as a clone of Bug #730691 +++

(perma-orange on SeaMonkey.)

Comment 1

[:Gijs (he/him)]

(In reply to Serge Gautherie (:sgautherie) from comment #0)
> +++ This bug was initially created as a clone of Bug #730691 +++
> 
> (perma-orange on SeaMonkey.)

rs=me for updating this.

But, fwiw, this sounds like we're fighting symptoms, and leaving the real cause (trees going perma-orange because of add-on compat) unfixed. That just shouldn't happen; as it is the add-ons will run because of 'compatible by default', right?

Comment 2

[Serge Gautherie (:sgautherie)]

http://hg.mozilla.org/venkman/rev/b6a784fb2a54


(In reply to Gijs Kruitbosch from comment #1)
> But, fwiw, this sounds like we're fighting symptoms, and leaving the real
> cause (trees going perma-orange because of add-on compat) unfixed. That just
> shouldn't happen; as it is the add-ons will run because of 'compatible by
> default', right?

Yes, but see bug 732749 comment 7 about the (current) situation.

Comment 3

[Serge Gautherie (:sgautherie)]

Attachment: Replace tabs with spaces [Checked in: Comment 8]

While here, one step toward more file synchronization.

Comment 4

[:Gijs (he/him)]

(In reply to Serge Gautherie (:sgautherie) from comment #3)
> Created attachment 606586 [details] [diff] [review]
> Replace tabs with spaces
> 
> While here, one step toward more file synchronization.

I'm confused, sorry. Synchronization with what? Why does the spacing matter?

Comment 5

[Serge Gautherie (:sgautherie)]

(In reply to Gijs Kruitbosch from comment #4)
> I'm confused, sorry. Synchronization with what? Why does the spacing matter?

Sync' one file with the other. Just a nit, nothing special.
Helps compare/edit/... them, just being more consistent, fwiw.

Comment 6

[Serge Gautherie (:sgautherie)]

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1331928910.1331934391.22023.gz
WINNT 5.2 comm-central-trunk debug test mochitest-other on 2012/03/16 13:15:10

V.Fixed

Comment 7

[:Gijs (he/him)]

Comment on attachment 606586 [details] [diff] [review]
Replace tabs with spaces
[Checked in: Comment 8]

(In reply to Serge Gautherie (:sgautherie) from comment #5)
> (In reply to Gijs Kruitbosch from comment #4)
> > I'm confused, sorry. Synchronization with what? Why does the spacing matter?
> 
> Sync' one file with the other. Just a nit, nothing special.
> Helps compare/edit/... them, just being more consistent, fwiw.

Next time, please just do it as part of the fix you've just done, and attach a diff -w for that.

rs=me

Comment 8

[Serge Gautherie (:sgautherie)]

Comment on attachment 606586 [details] [diff] [review]
Replace tabs with spaces
[Checked in: Comment 8]

https://hg.mozilla.org/venkman/rev/036e6bf7194d


(In reply to Gijs Kruitbosch from comment #7)
> Next time, please just do it as part of the fix you've just done, and attach
> a diff -w for that.

I'll try to remember.