intermittent browser/components/sessionstore/test/browser_625016.js | Test timed out, followed by other errors

RESOLVED FIXED in Firefox 14

Status

()

Firefox
Session Restore
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mak, Assigned: ttaubert)

Tracking

({intermittent-failure})

unspecified
Firefox 14
intermittent-failure
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
I'm including part of the previous test since there's an assert from Panorama that looks bogus
Looks like just after the timeout we correctly proceed and finish the test.

https://tbpl.mozilla.org/php/getParsedLog.php?id=10111419&tree=Fx-Team
https://tbpl.mozilla.org/php/getParsedLog.php?id=10115742&tree=Fx-Team
https://tbpl.mozilla.org/php/getParsedLog.php?id=10115738&tree=Fx-Team

INFO TEST-END | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_624727.js | finished in 118ms
TEST-INFO | checking window state
TEST-INFO | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_624727.js | Console message: trace: tabview assert: make sure the calculated rows, columns and maxColumns are correct
GroupItem_adjustAppTabTray(true)@chrome://browser/content/tabview.js:2897
("chrome://mozapps/skin/places/defaultFavicon.png")@chrome://browser/content/tabview.js:3674
GroupItems_getAppTabFavIconUrl_getFavIconUrlForTab(null)@chrome://browser/content/tabview.js:4559
(false)@chrome://browser/content/tabview.js:10306
onMessage([object Object])@chrome://browser/content/tabview.js:10256

TEST-INFO | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_624727.js | Console message: [JavaScript Warning: "Error in parsing value for '-moz-column-count'.  Declaration dropped." {file: "chrome://browser/content/tabview.html" line: 0}]
TEST-INFO | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_624727.js | Console message: [JavaScript Warning: "Error in parsing value for 'width'.  Declaration dropped." {file: "chrome://browser/content/tabview.html" line: 0}]
TEST-INFO | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_624727.js | Console message: [JavaScript Warning: "Error in parsing value for 'width'.  Declaration dropped." {file: "chrome://browser/content/tabview.html" line: 0}]
TEST-START | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_625016.js
TEST-PASS | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_625016.js | starting with no closed windows
TEST-PASS | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_625016.js | no closed windows on first save
TEST-INFO | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_625016.js | Longer timeout required, waiting longer...  Remaining timeouts: 1
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_625016.js | Test timed out

TEST-INFO | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_625016.js | observe1: sessionstore-state-write
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_625016.js | observe1: 2 windows in data being writted to disk - Got 1, expected 2
Stack trace:
    JS frame :: chrome://mochikit/content/browser-test.js :: test_is :: line 446
    JS frame :: chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_625016.js :: observe1 :: line 55
    JS frame :: resource:///components/nsSessionStore.js :: sss_saveStateObject :: line 3715
    JS frame :: resource:///components/nsSessionStore.js :: sss_saveState :: line 3702
    JS frame :: resource:///components/nsSessionStore.js :: sss_saveStateDelayed :: line 3641
    JS frame :: resource:///components/nsSessionStore.js :: sss_observe :: line 675
    JS frame :: chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_625016.js :: <TOP_LEVEL> :: line 23
    JS frame :: chrome://mochikit/content/browser-test.js :: Tester_nextTest :: line 242
    JS frame :: chrome://mochikit/content/browser-test.js :: <TOP_LEVEL> :: line 379
    native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0

TEST-PASS | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_625016.js | observe1: no closed windows in data being writted to disk
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_625016.js | observe1: 1 closed window according to API - Got 0, expected 1
Stack trace:
    JS frame :: chrome://mochikit/content/browser-test.js :: test_is :: line 446
    JS frame :: chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_625016.js :: observe1 :: line 61
    JS frame :: resource:///components/nsSessionStore.js :: sss_saveStateObject :: line 3715
    JS frame :: resource:///components/nsSessionStore.js :: sss_saveState :: line 3702
    JS frame :: resource:///components/nsSessionStore.js :: sss_saveStateDelayed :: line 3641
    JS frame :: resource:///components/nsSessionStore.js :: sss_observe :: line 675
    JS frame :: chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_625016.js :: <TOP_LEVEL> :: line 23
    JS frame :: chrome://mochikit/content/browser-test.js :: Tester_nextTest :: line 242
    JS frame :: chrome://mochikit/content/browser-test.js :: <TOP_LEVEL> :: line 379
    native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Summary: intermittent browser/components/sessionstore/test/browser_625016.js | Test timed out → intermittent browser/components/sessionstore/test/browser_625016.js | Test timed out, followed by other errors
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
(Assignee)

Comment 20

5 years ago
Created attachment 606905 [details] [diff] [review]
patch v1

The fix here is to call waitForSaveState() *before* opening a new window to provide a safe starting point for this test.

If we open a new window and a previous test already triggered the save-state timer it might notify our observer just after opening the window and closes it again before even being registered by SS.
Assignee: nobody → ttaubert
Status: NEW → ASSIGNED
Attachment #606905 - Flags: review?(mak77)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
(Reporter)

Comment 39

5 years ago
Comment on attachment 606905 [details] [diff] [review]
patch v1

hm, iirc I tried something similar (making the previous test wait) and still timed out.  Btw, this won't hurt.
Attachment #606905 - Flags: review?(mak77) → review+
(Assignee)

Comment 40

5 years ago
(In reply to Marco Bonardo [:mak] from comment #39)
> hm, iirc I tried something similar (making the previous test wait) and still
> timed out.  Btw, this won't hurt.

Thanks, this fixed the timeout on my windows box at least. We'll see how it goes.

https://hg.mozilla.org/integration/fx-team/rev/f671c3dc0f27
Whiteboard: [orange] → [orange][fixed-in-fx-team]
Target Milestone: --- → Firefox 14
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
(Assignee)

Comment 47

5 years ago
https://hg.mozilla.org/mozilla-central/rev/f671c3dc0f27
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [orange][fixed-in-fx-team] → [orange]
Comment hidden (Treeherder Robot)
Keywords: intermittent-failure
Whiteboard: [orange]
You need to log in before you can comment on or make changes to this bug.