73642 - Incorrect calling convention in JPEG

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Mike Kaply [:mkaply]]

In jmorecfg.h, the JPEG library defines METHODDEF for use when you are defining 
callbacks to the JPEG library. This #define is not used in any of our code, so 
for OS/2, we had to add PR_CALLBACK in jpeg.cpp.

The attached diff fixes libimg and libpr0n to use METHODDEF rather than a 
PR_CALLBACK and fixes jmorecfg.h to properly specify linkages in jpeg.

Note that I am continue to use PR_ stuff in libjpeg because otherwise I would 
have had to duplicate a lot of code for NSPR.

This at least moves all of the Moz specific callback stuff into one place.

I've also fixed JPEG to not use PR_PUBLIC_API as this is deprecated - in JPEG 
GLOBAL is equivalent to PR_IMPLEMENT and EXTERN is equivalent to PR_EXTERN. 
Finally, I've changed it to use PR_EXTERN_C macro rather than explicitly setting 
it.

Comment 1

[Mike Kaply [:mkaply]]

Attachment: Fix up callbacks in jpeg

Comment 2

[Mike Kaply [:mkaply]]

Attachment: Similar problem for PNGCOM - should use extern "C" since PNG uses extern "C"

Comment 3

[pnunn]

for pav.....

Comment 4

[Asa Dotzler [:asa]]

Bugs targeted at mozilla1.0 without the mozilla1.0 keyword moved to mozilla1.0.1 
(you can query for this string to delete spam or retrieve the list of bugs I've 
moved)

Comment 5

[Mike Kaply [:mkaply]]

Attachment: New patch against current trunk

Comment 6

[tor]

Comment on attachment 128276 [details] [diff] [review]
New patch against current trunk

Please add a line to MOZCHANGES.  sr=tor

Comment 7

[Mike Kaply [:mkaply]]

Fix checked in.