736429 - JSON data of GC/CC stats do contain spaces

Status: RESOLVED INVALID

(Core :: XPCOM, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

The API as implemented on bug 531396 is sending JSON data via observer messages. Sadly the keys for JSON properties contain blanks and can't be easily handled that way.

See also bug 531396 comment 27 where Bill stated:

> @@ +286,5 @@
> >      double mmu20 = computeMMU(20 * PRMJ_USEC_PER_MSEC);
> >      double mmu50 = computeMMU(50 * PRMJ_USEC_PER_MSEC);
> >  
> > +    ss.beginObject();
> > +    ss.appendNumber("TotalTime",    "%.1f",   "ms", t(total));
> 
> Here's my new thought on the key names (like TotalTime). We should write
> them out in normal English, with spaces, like "Total Time". That's how they
> would appear in the error console. And for JSON, we will convert to
> lowercase and replace spaces with underscores.
> 
> Also, please don't use extra spaces to line things up.

Please update the JSON data to make it easy for everyone to handle the data.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Darn. Please forget about this bug. I was getting confused by all the work we do between observers and console messages. We correctly send the data. Purely my fault. :( Marking as invalid.