Closed Bug 736437 Opened 12 years ago Closed 12 years ago

Chat accounts without protocol plugin aren't correctly handled

Categories

(Thunderbird :: Instant Messaging, defect)

defect
Not set
normal

Tracking

(thunderbird15 fixed)

RESOLVED FIXED
Thunderbird 16.0
Tracking Status
thunderbird15 --- fixed

People

(Reporter: florian, Assigned: florian)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch WIP (obsolete) — Splinter Review
To test this, apply the patch from bug 735215, create an XMPP account, then remove the patch from bug 735215.

The handling of this edge case doesn't have to be perfect, but I think it should at least be good enough for an user to be able to delete a leftover account.

The attached patch significantly improves the situation (the Account Settings dialog can display correctly the pane related to the account without protocol plugin), but removing the account doesn't fully work (some preferences are still there after a restart) so I'm not requesting a review yet.
Attached patch PatchSplinter Review
Requesting review from David for the Thunderbird account settings part (files in mail/components/im) and Patrick for the chat/ file.
Assignee: nobody → florian
Attachment #606532 - Attachment is obsolete: true
Attachment #634395 - Flags: review?(dbienvenu)
Attachment #634395 - Flags: review?(clokep)
Comment on attachment 634395 [details] [diff] [review]
Patch

All my review comments were already given over IRC @ http://log.bezut.info/instantbird/120619/#m259 and fixed before this version.
Attachment #634395 - Flags: review?(clokep) → review+
Comment on attachment 634395 [details] [diff] [review]
Patch

this looks reasonable, though the variable name "protocol" is so much more clear than "proto", especially in js code :-)
Attachment #634395 - Flags: review?(dbienvenu) → review+
https://hg.mozilla.org/comm-central/rev/c7c81c0bcc94
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 16.0
Comment on attachment 634395 [details] [diff] [review]
Patch

[Approval Request Comment]
User impact if declined: If users install additional protocol plugins as add-ons, and for some reason the add-on is no longer available (uninstalled by the user, incompatible with a newer version of Thunderbird, ...) it's impossible to delete the left-over chat account without this patch.
Attachment #634395 - Flags: approval-comm-aurora?
Attachment #634395 - Flags: approval-comm-aurora? → approval-comm-aurora+
You need to log in before you can comment on or make changes to this bug.