The default bug view has changed. See this FAQ.

Chat accounts without protocol plugin aren't correctly handled

RESOLVED FIXED in Thunderbird 16.0

Status

Thunderbird
Instant Messaging
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: florian, Assigned: florian)

Tracking

Trunk
Thunderbird 16.0

Thunderbird Tracking Flags

(thunderbird15 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Created attachment 606532 [details] [diff] [review]
WIP

To test this, apply the patch from bug 735215, create an XMPP account, then remove the patch from bug 735215.

The handling of this edge case doesn't have to be perfect, but I think it should at least be good enough for an user to be able to delete a leftover account.

The attached patch significantly improves the situation (the Account Settings dialog can display correctly the pane related to the account without protocol plugin), but removing the account doesn't fully work (some preferences are still there after a restart) so I'm not requesting a review yet.
(Assignee)

Comment 1

5 years ago
Created attachment 634395 [details] [diff] [review]
Patch

Requesting review from David for the Thunderbird account settings part (files in mail/components/im) and Patrick for the chat/ file.
Assignee: nobody → florian
Attachment #606532 - Attachment is obsolete: true
Attachment #634395 - Flags: review?(dbienvenu)
Attachment #634395 - Flags: review?(clokep)
Comment on attachment 634395 [details] [diff] [review]
Patch

All my review comments were already given over IRC @ http://log.bezut.info/instantbird/120619/#m259 and fixed before this version.
Attachment #634395 - Flags: review?(clokep) → review+

Comment 3

5 years ago
Comment on attachment 634395 [details] [diff] [review]
Patch

this looks reasonable, though the variable name "protocol" is so much more clear than "proto", especially in js code :-)
Attachment #634395 - Flags: review?(dbienvenu) → review+
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/comm-central/rev/c7c81c0bcc94
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 16.0
(Assignee)

Comment 5

5 years ago
Comment on attachment 634395 [details] [diff] [review]
Patch

[Approval Request Comment]
User impact if declined: If users install additional protocol plugins as add-ons, and for some reason the add-on is no longer available (uninstalled by the user, incompatible with a newer version of Thunderbird, ...) it's impossible to delete the left-over chat account without this patch.
Attachment #634395 - Flags: approval-comm-aurora?

Updated

5 years ago
Attachment #634395 - Flags: approval-comm-aurora? → approval-comm-aurora+
(Assignee)

Comment 6

5 years ago
https://hg.mozilla.org/releases/comm-aurora/rev/fe09587e027c
status-thunderbird15: --- → fixed
You need to log in before you can comment on or make changes to this bug.