Last Comment Bug 736441 - fix test descriptions in mozmill/composition
: fix test descriptions in mozmill/composition
Status: RESOLVED FIXED
:
Product: Thunderbird
Classification: Client Software
Component: General (show other bugs)
: unspecified
: All All
: -- normal (vote)
: Thunderbird 14.0
Assigned To: Magnus Melin
:
Mentors:
http://mxr.mozilla.org/comm-central/s...
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-03-16 05:17 PDT by Magnus Melin
Modified: 2012-03-19 11:59 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
proposed fix (8.16 KB, patch)
2012-03-16 05:17 PDT, Magnus Melin
mconley: review+
Details | Diff | Splinter Review

Description Magnus Melin 2012-03-16 05:17:47 PDT
Created attachment 606538 [details] [diff] [review]
proposed fix

If you look at http://mxr.mozilla.org/comm-central/source/mail/test/mozmill/composition/ a lot of file descriptions are missing/wrong. Also true for other directories...

This fixes them for mozmill/composition.
Comment 1 Mike Conley (:mconley) - (needinfo me!) 2012-03-19 07:59:32 PDT
Comment on attachment 606538 [details] [diff] [review]
proposed fix

Review of attachment 606538 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good.  Two nits.  Modulo those, r=me.

Thanks for your work,

-Mike

::: mail/test/mozmill/composition/test-attachment.js
@@ +35,5 @@
>   *
>   * ***** END LICENSE BLOCK ***** */
>  
> +/**
> + * Tests attachment handling functinality of the message compose window.

typo: functionality

::: mail/test/mozmill/composition/test-save-changes-on-quit.js
@@ +34,5 @@
>   *
>   * ***** END LICENSE BLOCK ***** */
>  
>  /**
> + * Tests what happens if you try to quit with a composition window that may

I'd prefer a description like,

"Tests that we prompt the user if they'd like to save their message when they try to quit with an open compose window with unsaved changes."
Comment 2 Magnus Melin 2012-03-19 11:59:50 PDT
http://hg.mozilla.org/comm-central/rev/1a8835139dfc -> FIXED

Note You need to log in before you can comment on or make changes to this bug.