Closed
Bug 736441
Opened 14 years ago
Closed 14 years ago
fix test descriptions in mozmill/composition
Categories
(Thunderbird :: General, defect)
Thunderbird
General
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 14.0
People
(Reporter: mkmelin, Assigned: mkmelin)
References
()
Details
Attachments
(1 file)
|
8.16 KB,
patch
|
mconley
:
review+
|
Details | Diff | Splinter Review |
If you look at http://mxr.mozilla.org/comm-central/source/mail/test/mozmill/composition/ a lot of file descriptions are missing/wrong. Also true for other directories...
This fixes them for mozmill/composition.
Attachment #606538 -
Flags: review?(mconley)
Comment 1•14 years ago
|
||
Comment on attachment 606538 [details] [diff] [review]
proposed fix
Review of attachment 606538 [details] [diff] [review]:
-----------------------------------------------------------------
This looks good. Two nits. Modulo those, r=me.
Thanks for your work,
-Mike
::: mail/test/mozmill/composition/test-attachment.js
@@ +35,5 @@
> *
> * ***** END LICENSE BLOCK ***** */
>
> +/**
> + * Tests attachment handling functinality of the message compose window.
typo: functionality
::: mail/test/mozmill/composition/test-save-changes-on-quit.js
@@ +34,5 @@
> *
> * ***** END LICENSE BLOCK ***** */
>
> /**
> + * Tests what happens if you try to quit with a composition window that may
I'd prefer a description like,
"Tests that we prompt the user if they'd like to save their message when they try to quit with an open compose window with unsaved changes."
Attachment #606538 -
Flags: review?(mconley) → review+
| Assignee | ||
Comment 2•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 14.0
You need to log in
before you can comment on or make changes to this bug.
Description
•