736472 - Ignore "devtools.inspector.enabled" preference

Status: RESOLVED DUPLICATE of bug 736465

(DevTools :: Inspector, defect, P2)

Description

[Paul Rouget [:paul]]

Some users use "devtools.inspector.enabled" to disable the "inspect" menu entry in the context menu. Once we will get the a specific pref for disabling this entry, we should consider not disabling the inspector if "devtools.inspector.enabled" is false.

Comment 1

[Dave Camp (:dcamp)]

That pref was originally intended as a kill switch during development of the inspector feature.  Now that we've shipped, disabling that pref gets almost no testing, so this suggestion makes sense.

Comment 2

[Chris Cunningham]

What's the transition plan for users who have already flipped the pref? Would they automatically have the new UI pref defaulted to off (assuming, for some strange reason, that it defaulted to on), or would they have to hunt for the new pref to get their old behaviour back?

Comment 3

[Paul Rouget [:paul]]

(In reply to Chris Cunningham from comment #2)
> What's the transition plan for users who have already flipped the pref?
> Would they automatically have the new UI pref defaulted to off (assuming,
> for some strange reason, that it defaulted to on), or would they have to
> hunt for the new pref to get their old behaviour back?

I guess we can assume that people who preffed off the inspector did it because of the menuitem.
So we could just have some transition code that would use the initial pref as a default value.

Comment 4

[Rob Campbell [:rc] (:robcee)]

I would suggest:

devtools.inspector.contextMenu.enabled for your preference.

For users with explicitly-disabled devtools.inspector.enabled prefs, we could automatically set .contextMenu to false.

make sense?

Comment 5

[Dave Camp (:dcamp)]

Let's try to get this for 16.