Closed
Bug 736547
Opened 12 years ago
Closed 12 years ago
Port |Bug 735625 - Get rid of ImportHTMLFromFileToFolder| to SeaMonkey
Categories
(SeaMonkey :: Bookmarks & History, defect)
SeaMonkey
Bookmarks & History
Tracking
(Not tracked)
VERIFIED
FIXED
seamonkey2.11
People
(Reporter: InvisibleSmiley, Assigned: InvisibleSmiley)
References
Details
(Whiteboard: [perma-orange])
Attachments
(1 file)
6.81 KB,
patch
|
sgautherie
:
review+
|
Details | Diff | Splinter Review |
Serge, if you want to do more cleanup here, please take over and get review from someone else. Thanks!
Attachment #606652 -
Flags: review?(sgautherie.bz)
Comment 1•12 years ago
|
||
Comment on attachment 606652 [details] [diff] [review] patch [Checkin: See comment 3] Review of attachment 606652 [details] [diff] [review]: ----------------------------------------------------------------- While here, can you sync' the "The Initial Developer ..." line too? http://mxr.mozilla.org/comm-central/find?string=%2Fplaces%2Ftests%2Funit%2F ::: suite/common/places/tests/unit/test_bookmarks_html.js @@ -153,5 @@ > - } catch(ex) { do_throw("couldn't import the exported file to folder: " + ex); } > - testCanonicalBookmarks(testFolder); > - bmsvc.removeFolder(testFolder); > - > - // XXX Disabled due to bug 381129 - separators will be duplicated on re-import Leave that 3rd test in: afaict it's still present in the Firefox file. @@ -175,5 @@ > - } catch(ex) { do_throw("couldn't import the exported file: " + ex); } > - testCanonicalBookmarks(bmsvc.bookmarksMenuFolder); > - */ > - /* > - XXX if there are new fields we add to the bookmarks HTML format Leave this comment block in: it will be removed in bug 731663.
Attachment #606652 -
Flags: review?(sgautherie.bz) → review+
Comment 2•12 years ago
|
||
Ftr, current state is: { TEST-UNEXPECTED-FAIL | e:/builds/slave/test/build/xpcshell/tests/suite/common/places/tests/unit/test_bookmarksRestoreNotification.js | Restore should not have failed - See following stack: }
Severity: trivial → major
Component: Testing Infrastructure → Bookmarks & History
Depends on: 735625
QA Contact: testing-infrastructure → bookmarks
Whiteboard: [perma-orange]
Assignee | ||
Comment 3•12 years ago
|
||
Comment on attachment 606652 [details] [diff] [review] patch [Checkin: See comment 3] (In reply to Serge Gautherie (:sgautherie) from comment #1) > Leave that 3rd test in: afaict it's still present in the Firefox file. [I don't think it makes a lot of sense to leave something in that is commented out and probably not factually correct anymore in our version, but I'm OK with not changing it here.] http://hg.mozilla.org/comm-central/rev/9198f3df8613
Attachment #606652 -
Attachment description: patch → patch [Checkin: Comment 3]
Assignee | ||
Updated•12 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment 4•12 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1332077852.1332080781.21051.gz OS X 10.5 comm-central-trunk debug test xpcshell on 2012/03/18 06:37:32 V.Fixed
Status: RESOLVED → VERIFIED
Flags: in-testsuite+
Comment 5•12 years ago
|
||
(In reply to Jens Hatlak (:InvisibleSmiley) from comment #3) > [I don't think it makes a lot of sense to leave something in that is > commented out and probably not factually correct anymore in our version I don't know about the "not factually correct" part, but I'm un-commenting out that test in bug 731663...
Updated•12 years ago
|
Attachment #606652 -
Attachment description: patch [Checkin: Comment 3] → patch [Checkin: See comment 3]
Updated•12 years ago
|
Summary: Port tests parts of |Bug 735625 - Get rid of ImportHTMLFromFileToFolder| to suite → Port |Bug 735625 - Get rid of ImportHTMLFromFileToFolder| to SeaMonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•