736549 - Dont link to NSS functions unless we need them

Status: RESOLVED INVALID

(Firefox for Android Graveyard :: General, defect)

Description

[Wesley Johnston (:wesj)]

I'm trying to figure out if my recent NSS changes are causing 736289. My theory is maybe NSS_Initialize is being called twice in the same process. I'm not exactly sure how that happens due to my code, which should only be hit if you actually call into the PasswordsProvider during startup, which shouldn't happen.

This does two things:

1.) Removes some unnecessary nss initialization in form history (Its possible we are hitting this in the same proceess as Gecko...) and in tests. NSSBridge does the correct initialization for us.

2.) Adds a boolean parameter to loadNSSLibs so that we don't bother linking to NSS functions if we don't want them. Callers will still have to be careful.

I feel like there's a smarter solution here, but its alluding me right now...

Comment 1

[Wesley Johnston (:wesj)]

Attachment: Patch

Whoops. This patch.

Comment 2

[Brad Lassey [:blassey] (use needinfo?)]

I think I'd rather have ensureNSSLoaded() which protects uses a static boolean to return early if its already been called. Would that fix this particular bug? or am I missing something here?

Comment 3

[Wesley Johnston (:wesj)]

Nope. We have that in fact!

I was worried somehow these functions were being called from the Gecko process and causing crashes, but it looks like that was a different bug anyway. I'll just resolve this invalid if thats ok.