736556 - A changed account nickname breaks previously generated vouch urls

Status: VERIFIED FIXED

(Participation Infrastructure :: Phonebook, defect)

Description

[Matt Brandt [:mbrandt]]

Once a user sets their nickname or updates their existing nickname the url used to vouch for that account breaks.

The situation that I'm primary concerned with is if a user updates their nick shortly after sending their vouch-for-me url to the world and the confusion/user experience that could ensue while they are attempting to become a vouched mozillian.

Steps to reproduce:
1. create a new account but do not set a nickname
2. collect the account url to be vouched
3. update user's nickname
4. note the account url to be vouched for has changed
5  try to locate the account with the previous url in step 2

example:
https://mozillians-dev.allizom.org/en-US/u/u4_cuEWSDcA2MO-KR9OrHRSQXvQ updates to https://mozillians-dev.allizom.org/en-US/hot

Expected:
The previous hash that represents the user should continue to allow users to find and vouch for that account.

Actual:
A 404 is returned.
[11:43:32.147] GET https://mozillians-dev.allizom.org/en-US/u4_cuEWSDcA2MO-KR9OrHRSQXvQ [HTTP/1.1 404 NOT FOUND 206ms]

Comment 1

[tofumatt [:tofumatt]]

So the best way to fix this, I think, is just to let unvouched users know that after they've changed their username, their URL has changed, and they'll need to resend their profile URL to someone. We can get this in this release, but it requires strings, so they won't be localized in time for tomorrow.

I'd rather some users get this fix than none, and it would be localized for next release, so shall we land this on production as well as master?

Thoughts?

Comment 2

[Aakash Desai [:aakashd]]

Sounds good to me

Comment 3

[tofumatt [:tofumatt]]

Note that I _don't_ think the previous hash should be expected to work like mbrandt said, because that means we just start burning through URLs and saving a history for users. In the future I'd rather username just be a required field on registration, but we can chat about that some other time.

Comment 4

[[github robot]]

Commit pushed to master at https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/b4975acd595d7aea7035ebb9fdb81ed7699728a7
Tell users of profile URL change (fix bug 736556)

Notify any new, unvouched users that changing their nickname also
changes their profile URL (so they know to send it out again to get vouched).

Comment 5

[Matt Brandt [:mbrandt]]

Attachment: qa - verified

QA verified on stage - an informational message is raised notifying the user that their vouch url has changed.