If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Account deletion: ensure the users nick is sanitized

VERIFIED FIXED

Status

Participation Infrastructure
Phonebook
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: mbrandt, Assigned: tallOwen)

Tracking

Details

(Whiteboard: [rel:03/21/2012], URL)

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
Created attachment 606667 [details]
qa - hot-sauce

It appears that nicknames are not being "deleted" which is interfering with other accounts trying to assume previously used nicknames.

To capture the spec that this was designed towards - per :tallowens email:

We don't delete the actual row in the database anymore, now we just clear all of their data from the app. (Instead of removing the object, we leave the shell of the user). 

This is useful for when one user points to a specific other user who might delete their account. That code is here: (https://github.com/mozilla/mozillians/blob/prod/apps/users/models.py#L138).

Steps to reproduce:
1. account A - assume the nickname "hot-sauce"
2. delete account A
3. create account B - assume the nickname "hot-sauce"

Expected:
The nickname "hot-sauce" should be available for reuse.

Actual:
It is not - "This username is in use. Please try another."
(Assignee)

Updated

6 years ago
Assignee: nobody → owen
(Reporter)

Updated

6 years ago
Whiteboard: [rel:03/21/2012]
(Assignee)

Comment 1

6 years ago
Pull request created: https://github.com/mozilla/mozillians/pull/168
(Reporter)

Updated

6 years ago
Summary: Account deletion: ensure the users nick is scrubbed → Account deletion: ensure the users nick is sanitized

Comment 2

6 years ago
Commits pushed to master at https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/a707525531341a0be456bbfc465024d4246edf6c
bug736562: usernames don't get properly sanitized

Added tests that make sure its done

https://github.com/mozilla/mozillians/commit/4a31983b636f105b45729ffc09fcdf4d4f392f5b
Merge pull request #168 from tallowen/username_issues

bug736562: usernames don't get properly sanitized
(Assignee)

Comment 3

6 years ago
https://github.com/mozilla/mozillians/commits/prod The commit is on the "prod" branch, however stage server needs to be re-synced up with the "prod" branch.
(Reporter)

Comment 4

6 years ago
Bumping to resolved fixed per comment 3. Once stage is synced with the prod branch QA will verify.
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Comment 5

6 years ago
Stage is running the prod branch of code.
(Reporter)

Comment 6

6 years ago
(In reply to Matthew Riley MacPherson [:tofumatt] from comment #5)
> Stage is running the prod branch of code.

Good stuff - I should have been a bit more explicit, I'm waiting on bug 735755 to get resolved before diving into verification of the features that have landed.
(Reporter)

Comment 7

6 years ago
copy/paste fail - I meant bug 737674
(Reporter)

Comment 8

6 years ago
QA verified on stage - user nickname's are now recyclable once an account is deleted.
Status: RESOLVED → VERIFIED
(Reporter)

Updated

6 years ago
Component: mozillians.org → Phonebook
Product: Websites → Community Tools
QA Contact: mozillians-org → phonebook
Version: unspecified → other
You need to log in before you can comment on or make changes to this bug.