736562 - Account deletion: ensure the users nick is sanitized

Status: VERIFIED FIXED

(Participation Infrastructure :: Phonebook, defect)

Description

[Matt Brandt [:mbrandt]]

Attachment: qa - hot-sauce

It appears that nicknames are not being "deleted" which is interfering with other accounts trying to assume previously used nicknames.

To capture the spec that this was designed towards - per :tallowens email:

We don't delete the actual row in the database anymore, now we just clear all of their data from the app. (Instead of removing the object, we leave the shell of the user). 

This is useful for when one user points to a specific other user who might delete their account. That code is here: (https://github.com/mozilla/mozillians/blob/prod/apps/users/models.py#L138).

Steps to reproduce:
1. account A - assume the nickname "hot-sauce"
2. delete account A
3. create account B - assume the nickname "hot-sauce"

Expected:
The nickname "hot-sauce" should be available for reuse.

Actual:
It is not - "This username is in use. Please try another."

Comment 1

[Owen Coutts [:tallOwen]]

Pull request created: https://github.com/mozilla/mozillians/pull/168

Comment 2

[[github robot]]

Commits pushed to master at https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/a707525531341a0be456bbfc465024d4246edf6c
bug736562: usernames don't get properly sanitized

Added tests that make sure its done

https://github.com/mozilla/mozillians/commit/4a31983b636f105b45729ffc09fcdf4d4f392f5b
Merge pull request #168 from tallowen/username_issues

bug736562: usernames don't get properly sanitized

Comment 3

[Owen Coutts [:tallOwen]]

https://github.com/mozilla/mozillians/commits/prod The commit is on the "prod" branch, however stage server needs to be re-synced up with the "prod" branch.

Comment 4

[Matt Brandt [:mbrandt]]

Bumping to resolved fixed per comment 3. Once stage is synced with the prod branch QA will verify.

Comment 5

[tofumatt [:tofumatt]]

Stage is running the prod branch of code.

Comment 6

[Matt Brandt [:mbrandt]]

(In reply to Matthew Riley MacPherson [:tofumatt] from comment #5)
> Stage is running the prod branch of code.

Good stuff - I should have been a bit more explicit, I'm waiting on bug 735755 to get resolved before diving into verification of the features that have landed.

Comment 7

[Matt Brandt [:mbrandt]]

copy/paste fail - I meant bug 737674

Comment 8

[Matt Brandt [:mbrandt]]

QA verified on stage - user nickname's are now recyclable once an account is deleted.