736673 - Redis version in vagrant image is out of date

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Code Quality, defect, P4)

Description

[Wraithan (Chris McDonald) [:wraithan]]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:11.0) Gecko/20100101 Firefox/11.0
Build ID: 20120228210006

Steps to reproduce:

I attempted to submit an add-on to my copy of Zamboni that I have running via vagrant.


Actual results:

A long traceback resulting in: "ResponseError: unknown command 'HINCRBY'".


Expected results:

This command became available in v1.3.10 of Redis. This version of Redis needs to either be bundled with the image that is distributed or vagrant should upgrade to this version at least. Preferably it should upgrade to the version of Redis used in production for AMO

Comment 1

[Andrew Williamson [:eviljeff]]

Co-opting this bug as its seems to be the same issue that I was talking with kumar about on irc.

sudo apt-get install redis-server doesn't upgrade to a higher version which you would expect it to if it was the version being too low.

redis-server --version /etc/redis/redis.conf and other variants fail, sometimes with a config error so it could that instead.

Comment 2

[Kumar McMillan [:kumar]]

I'm running out of time for this up against the other upcoming milestones. If anyone ends up working on it while getting a vagrant env going then please submit a patch or command line instructions for what you did.

Comment 3

[Hector Zhao [:hectorz]]

The latest version of redis-server provided by 10.04 lts is 1.2.0[1], redis-server from this ppa[2] works fine for me:

    sudo add-apt-repository ppa:cmsj/redis-stable
    sudo apt-get update
    sudo apt-get install redis-server

[1]: http://packages.ubuntu.com/lucid/redis-server
[2]: https://launchpad.net/~cmsj/+archive/redis-stable

Comment 4

[Kumar McMillan [:kumar]]

Thanks Hector! I updated the vagrant scripts for that https://github.com/mozilla/zamboni/commit/d719c65d2b4ae8304b8acafb43a078360b1a9dd4 It seems to be working.