Last Comment Bug 736743 - Fix OGLComment
: Fix OGLComment
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Graphics (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla14
Assigned To: Benoit Girard (:BenWa)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-03-17 09:34 PDT by Benoit Girard (:BenWa)
Modified: 2012-03-18 13:10 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (977 bytes, patch)
2012-03-17 09:34 PDT, Benoit Girard (:BenWa)
ajuma.bugzilla: review+
Details | Diff | Review
Bug %s patch (988 bytes, patch)
2012-03-17 09:43 PDT, Benoit Girard (:BenWa)
no flags Details | Diff | Review
Fix LayerManagerOGL Description. (1.00 KB, patch)
2012-03-17 09:44 PDT, Benoit Girard (:BenWa)
no flags Details | Diff | Review

Description Benoit Girard (:BenWa) 2012-03-17 09:34:15 PDT

    
Comment 1 Benoit Girard (:BenWa) 2012-03-17 09:34:23 PDT
Created attachment 606878 [details] [diff] [review]
patch
Comment 2 Ali Juma [:ajuma] 2012-03-17 09:40:33 PDT
Comment on attachment 606878 [details] [diff] [review]
patch

Review of attachment 606878 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/opengl/LayerManagerOGL.h
@@ +79,5 @@
>  class ShadowCanvasLayer;
>  class ShadowColorLayer;
>  
>  /**
> + * This is the LayerManager used for OpenGL 2.1. This can be used either on

While we're fixing this, we should also change "OpenGL 2.1" to "OpenGL 2.1 and OpenGL ES 2.0" (or, if you prefer, keep it generic and just have "OpenGL").
Comment 3 Benoit Girard (:BenWa) 2012-03-17 09:43:23 PDT
Created attachment 606880 [details] [diff] [review]
Bug %s patch
Comment 4 Benoit Girard (:BenWa) 2012-03-17 09:44:50 PDT
Created attachment 606881 [details] [diff] [review]
Fix LayerManagerOGL Description.
Comment 6 Phil Ringnalda (:philor) 2012-03-18 13:10:08 PDT
https://hg.mozilla.org/mozilla-central/rev/740ff2b02b80

Note You need to log in before you can comment on or make changes to this bug.