Note: There are a few cases of duplicates in user autocompletion which are being worked on.

filter editor dialog uses different minus signs on buttons to remove filter rules and filter actions

RESOLVED FIXED in Thunderbird 14.0

Status

MailNews Core
Filters
--
minor
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: aceman, Assigned: aceman)

Tracking

({polish, ux-consistency})

Trunk
Thunderbird 14.0
polish, ux-consistency
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Unify the character used for minus signs on buttons to remove filter rules and filter actions in the Filter editor.
I suggest to use \u2212 character as that one is rendered longer and in line with the plus sign. It is already used on the remove filter rule button.
(Assignee)

Comment 1

5 years ago
Created attachment 606984 [details] [diff] [review]
patch
Attachment #606984 - Flags: ui-review?(bwinton)
Attachment #606984 - Flags: review?(bwinton)
(Assignee)

Comment 2

5 years ago
I just noticed those buttons (for actions) do not have a tooltip text. The same buttons in terms definition above do have tooltips.
What about throwing that in too?
(In reply to :aceman from comment #2)
> I just noticed those buttons (for actions) do not have a tooltip text. The
> same buttons in terms definition above do have tooltips.
> What about throwing that in too?

Yes and are they accessible ?
(Assignee)

Comment 4

5 years ago
Do you mean accesskeys? Looks like they do not.
Comment on attachment 606984 [details] [diff] [review]
patch

Looks better, and the code seems fine.  I'ld like it to be accessible, but if you want to do that in a separate bug that's okay.

r=me, ui-r=me.

Thanks,
Blake.
Attachment #606984 - Flags: ui-review?(bwinton)
Attachment #606984 - Flags: ui-review+
Attachment #606984 - Flags: review?(bwinton)
Attachment #606984 - Flags: review+
(Assignee)

Comment 6

5 years ago
OK, I'll look at that in a new bug. Reviews are not that abundant to throw them away once granted:)
Keywords: checkin-needed
(Assignee)

Updated

5 years ago
Blocks: 742472
http://hg.mozilla.org/comm-central/rev/7cdd63e88115
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 14.0
You need to log in before you can comment on or make changes to this bug.