Last Comment Bug 736860 - filter editor dialog uses different minus signs on buttons to remove filter rules and filter actions
: filter editor dialog uses different minus signs on buttons to remove filter r...
Status: RESOLVED FIXED
: polish, ux-consistency
Product: MailNews Core
Classification: Components
Component: Filters (show other bugs)
: Trunk
: All All
: -- minor (vote)
: Thunderbird 14.0
Assigned To: :aceman
:
Mentors:
Depends on:
Blocks: 742472
  Show dependency treegraph
 
Reported: 2012-03-18 09:44 PDT by :aceman
Modified: 2012-04-05 15:24 PDT (History)
3 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch (1.41 KB, patch)
2012-03-18 09:59 PDT, :aceman
bwinton: review+
bwinton: ui‑review+
Details | Diff | Splinter Review

Description :aceman 2012-03-18 09:44:35 PDT
Unify the character used for minus signs on buttons to remove filter rules and filter actions in the Filter editor.
I suggest to use \u2212 character as that one is rendered longer and in line with the plus sign. It is already used on the remove filter rule button.
Comment 1 :aceman 2012-03-18 09:59:01 PDT
Created attachment 606984 [details] [diff] [review]
patch
Comment 2 :aceman 2012-03-27 04:40:53 PDT
I just noticed those buttons (for actions) do not have a tooltip text. The same buttons in terms definition above do have tooltips.
What about throwing that in too?
Comment 3 Ludovic Hirlimann [:Usul] 2012-03-28 06:33:03 PDT
(In reply to :aceman from comment #2)
> I just noticed those buttons (for actions) do not have a tooltip text. The
> same buttons in terms definition above do have tooltips.
> What about throwing that in too?

Yes and are they accessible ?
Comment 4 :aceman 2012-03-28 10:42:16 PDT
Do you mean accesskeys? Looks like they do not.
Comment 5 Blake Winton (:bwinton) (:☕️) 2012-04-04 11:39:46 PDT
Comment on attachment 606984 [details] [diff] [review]
patch

Looks better, and the code seems fine.  I'ld like it to be accessible, but if you want to do that in a separate bug that's okay.

r=me, ui-r=me.

Thanks,
Blake.
Comment 6 :aceman 2012-04-04 12:05:26 PDT
OK, I'll look at that in a new bug. Reviews are not that abundant to throw them away once granted:)
Comment 7 Ryan VanderMeulen [:RyanVM] 2012-04-05 15:24:53 PDT
http://hg.mozilla.org/comm-central/rev/7cdd63e88115

Note You need to log in before you can comment on or make changes to this bug.