Speed up building of layout/svg/base/src by cleaning up #include directives in its header files

RESOLVED FIXED in mozilla14

Status

()

Core
SVG
RESOLVED FIXED
6 years ago
4 years ago

People

(Reporter: jwatt, Assigned: jwatt)

Tracking

(Blocks: 2 bugs)

Trunk
mozilla14
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [include-what-you-use])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
Created attachment 607009 [details] [diff] [review]
patch

This is the equivalent of bug 721131, but for layout/svg/base/src header files. This patch cleans up the header files to make them include what they use, and nothing more.

For me, I get a 13% speed up for a warm, full rebuild in that directory.
Attachment #607009 - Flags: review?(dholbert)
(Assignee)

Comment 1

6 years ago
Created attachment 607014 [details] [diff] [review]
patch

Turns out there were a few other places outside of the SVG code that were depending on SVG headers to include headers that they need.
Attachment #607009 - Attachment is obsolete: true
Attachment #607009 - Flags: review?(dholbert)
Attachment #607014 - Flags: review?(dholbert)
Comment on attachment 607014 [details] [diff] [review]
patch

Looks good to me.

I didn't bother to verify that all the added #includes and 'class'/'struct' declarations are actually necessary -- I'm trusting you and the include-what-you-use tool on that.

(Plus, even if this did add an extraneous #include or declaration, it shouldn't really cause any problems, and this would still be a net win.)
Attachment #607014 - Flags: review?(dholbert) → review+
https://hg.mozilla.org/mozilla-central/rev/c64ab2ce86a0
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
(Assignee)

Updated

6 years ago
Blocks: 738969

Updated

4 years ago
Blocks: 903843
You need to log in before you can comment on or make changes to this bug.