Closed
Bug 736890
Opened 12 years ago
Closed 12 years ago
Speed up building of layout/svg/base/src by cleaning up #include directives in its header files
Categories
(Core :: SVG, defect)
Core
SVG
Tracking
()
RESOLVED
FIXED
mozilla14
People
(Reporter: jwatt, Assigned: jwatt)
References
(Blocks 1 open bug)
Details
(Whiteboard: [include-what-you-use])
Attachments
(1 file, 1 obsolete file)
|
45.32 KB,
patch
|
dholbert
:
review+
|
Details | Diff | Splinter Review |
This is the equivalent of bug 721131, but for layout/svg/base/src header files. This patch cleans up the header files to make them include what they use, and nothing more. For me, I get a 13% speed up for a warm, full rebuild in that directory.
Attachment #607009 -
Flags: review?(dholbert)
|
Assignee | |
Comment 1•12 years ago
|
||
Turns out there were a few other places outside of the SVG code that were depending on SVG headers to include headers that they need.
Attachment #607009 -
Attachment is obsolete: true
Attachment #607009 -
Flags: review?(dholbert)
Attachment #607014 -
Flags: review?(dholbert)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 607014 [details] [diff] [review] patch Looks good to me. I didn't bother to verify that all the added #includes and 'class'/'struct' declarations are actually necessary -- I'm trusting you and the include-what-you-use tool on that. (Plus, even if this did add an extraneous #include or declaration, it shouldn't really cause any problems, and this would still be a net win.)
Attachment #607014 -
Flags: review?(dholbert) → review+
|
||
Comment 3•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c64ab2ce86a0
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
You need to log in
before you can comment on or make changes to this bug.
Description
•