736920 - mochitest-robocop log parser shouldn't repeat the whole test log, particularly not with spurious blank lines

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Phil Ringnalda (:philor)]

Bug 717018 added a log parser, to count up the pass/fail in each separately-run mochitest-robocop test and print a summary total at the end.

https://hg.mozilla.org/mozilla-central/annotate/7be822540243/testing/mochitest/runtestsremote.py#l401 mentions a worry that "we might be duplicating output" but I don't see any "might" about it, nor do I see any reason why #l404 would want to join the individual lines, which apparently have newlines of their own, with "\n", so that the end result looks like https://tbpl.mozilla.org/php/getParsedLog.php?id=10171054&tree=Mozilla-Inbound#error1, blank lines between each line of what's actually duplicated content with its context removed.

Is there more I'm not seeing, that makes for a reason to not just have it count pass/fail quietly to itself, and then print out only that?

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

yes, I have been frustrated with this as well, I am going to just do the final summary bits.

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: do not print out lines that we have seen before, only summary (1.0)

Comment 3

[Geoff Brown [:gbrown]]

Comment on attachment 607196 [details] [diff] [review]
do not print out lines that we have seen before, only summary (1.0)

Review of attachment 607196 [details] [diff] [review]:
-----------------------------------------------------------------

As discussed: I support removal of duplicated messages, but this change removes all detail messages, at least when run with adb and TEST_PATH set.

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: do not print out lines that we have seen before, only summary (2.0)

it looks like devicemanagerADB.py had a bug where getFile would fail and not return the stdout.  Not sure why this wasn't handled differently, but now things work.

Comment 5

[Geoff Brown [:gbrown]]

Comment on attachment 608007 [details] [diff] [review]
do not print out lines that we have seen before, only summary (2.0)

Review of attachment 608007 [details] [diff] [review]:
-----------------------------------------------------------------

This works fine now.

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/78f463ab6dbb

Comment 7

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/78f463ab6dbb