736995 - Sharing option is active when attempting to share files inside omni.ja! archives

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Adrian Tamas (:AdrianT)]

Attachment: share is active for the resource protocol

Fennec/14.0a1 2012-03-18
Device: HTC Desire (Android 2.2)

Steps to reproduce:
1. Open Nightly.
2. Load resource: or any subdirectory.
3. Open the System Menu and tap on the share button

Expected results:
The share option is grayed out for unsupported protocols like about:,file:, or resource:

Actual results:
The button is active and can be used to share the link.

Comment 1

[Aaron Train [:aaronmt]]

bug 703630 special cased different URI schemes. According to the screenshot, you're actually attempting to share local resources found in the Android package omni.ja! archives. That is beyond edge case. This is likely WONT FIX.

Comment 2

[Adrian Tamas (:AdrianT)]

The screenshot is the result of accessing "resources:". The behavior is the same accessing subdirectories using "resources:///res/" for example to access the "res" folder. According to https://litmus.mozilla.org/show_test.cgi?id=48676 the share option should be disabled.

Comment 3

[Matt Brubeck (:mbrubeck)]

Attachment: patch

trivial fix

Comment 4

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7e6aa4bedc46

Comment 5

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/7e6aa4bedc46

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/ef36968c5e13

Comment 7

[Paul Feher]

Verified/fixed on:

Aurora Fennec 13.0a2 (2012-03-25)
Nightly Fennec 14.0a1 (2012-03-25)
Device: Samsung Nexus S
OS: Android 2.3.6