Closed
Bug 737012
Opened 13 years ago
Closed 11 years ago
nsXULPrototypeDocument::gSystemPrincipal never gets set
Categories
(Core :: XUL, defect)
Core
XUL
Tracking
()
RESOLVED
DUPLICATE
of bug 993772
People
(Reporter: neil, Assigned: n.nethercote)
References
Details
(Keywords: regression, Whiteboard: [MemShrink:P2])
Attachments
(1 file)
|
3.89 KB,
patch
|
Details | Diff | Splinter Review |
The patch in bug 354693 removed the assignment to nsXULPrototypeDocument::gSystemPrincipal, which means that chrome XUL documents no longer get to share a system global.
I don't know whether this is relevant, but I stumbled over this trying to work out why XUL documents don't compile with strict mode enabled.
|
||
Comment 1•13 years ago
|
||
Hmm. We should probably just compare to the system principal in content utils instead, no? Assuming this is desired at all, of course. Is it desired?
|
||
Updated•11 years ago
|
Whiteboard: [MemShrink]
|
|
||
Comment 2•11 years ago
|
||
After almost two years, I'm not sure this qualifies as a "regression". Nils did some analysis in bug 956883 comment 6.
|
|
Assignee | |
Comment 3•11 years ago
|
||
bz: can you explain what needs to be fixed here? I can evaluate the impact of any such fix.
|
|
Assignee | |
Updated•11 years ago
|
Flags: needinfo?(bzbarsky)
Whiteboard: [MemShrink] → [MemShrink:P2]
|
|
||
Comment 4•11 years ago
|
||
Basically just nix gSystemPrincipal entirely and replace its uses by nsContentUtils::GetSystemPrincipal().
Flags: needinfo?(bzbarsky)
|
|
||
Comment 5•11 years ago
|
||
|
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → n.nethercote
|
||
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•