Re-enable pedantic builds on Linux 32 bit mozconfigs

RESOLVED FIXED in Thunderbird 14.0


Build Config
5 years ago
5 years ago


(Reporter: standard8, Assigned: standard8)


Thunderbird 14.0

Thunderbird Tracking Flags

(thunderbird12+ fixed, thunderbird13 fixed, thunderbird-esr1012+ fixed)



(3 attachments)

Created attachment 607164 [details] [diff] [review]
Buildbot-configs patch

Way back just before we moved to libxul/ipc based builds, we had some hacks in our makefiles to get away with keep on being broken by pedantic compiler raised issues, when Firefox were disabling it for parts of libxul based builds.

The hack was to add -disable-pedantic.

We long since switched to libxul and IPC enabled builds, so we should just remove those hacks. Try server has been this way forever, if not a long time ;-)
Attachment #607164 - Flags: review?(jhopkins)
Created attachment 607165 [details] [diff] [review]
comm-central patch
Assignee: nobody → mbanner
Attachment #607165 - Flags: review?(jhopkins)
Attachment #607164 - Flags: review?(jhopkins) → review+
Attachment #607165 - Flags: review?(jhopkins) → review+
Per IRC, we'll also want to change the Linux 'release' mozconfigs at the end of the cycle when we release Thunderbird 12.
Could change esr10 mozconfigs at the same time?
Comment on attachment 607165 [details] [diff] [review]
comm-central patch

Checked in the comm-central patch:
Comment on attachment 607164 [details] [diff] [review]
Buildbot-configs patch

Checked in:
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 14.0
Comment on attachment 607165 [details] [diff] [review]
comm-central patch

[Triage Comment]
We landed the configs on aurora as well, so we should take this there to be consistent.
Attachment #607165 - Flags: approval-comm-aurora+
(or rather, they landed before the merge)
Checked into aurora:

Also setting flags so we track this for the 12 final release and the 12 ESR equivalent.
status-thunderbird13: --- → fixed
tracking-thunderbird12: --- → +
tracking-thunderbird-esr10: --- → 12+
Whiteboard: [need final changes for 12 release & ESR 12 equivalent]
Created attachment 615889 [details] [diff] [review]
Fix buildbot-configs for esr/release

This is the patch that's ready to land for release of 12/esr10.
Attachment #615889 - Flags: review?(jhopkins)
Due to the releases, I've landed the last patch pending review:
status-thunderbird12: --- → fixed
status-thunderbird-esr10: --- → fixed
Whiteboard: [need final changes for 12 release & ESR 12 equivalent]
Attachment #615889 - Flags: review?(jhopkins) → review+
Comment on attachment 607165 [details] [diff] [review]
comm-central patch

[Triage Comment]
Taking this onto esr as well, as we'll need it there, and currently its NPOTB.
Attachment #607165 - Flags: approval-comm-esr10+
Checked in:
You need to log in before you can comment on or make changes to this bug.