Closed
Bug 737028
Opened 12 years ago
Closed 12 years ago
Re-enable pedantic builds on Linux 32 bit mozconfigs
Categories
(Thunderbird :: Build Config, defect)
Thunderbird
Build Config
Tracking
(thunderbird12+ fixed, thunderbird13 fixed, thunderbird-esr1012+ fixed)
RESOLVED
FIXED
Thunderbird 14.0
People
(Reporter: standard8, Assigned: standard8)
References
Details
Attachments
(3 files)
|
3.59 KB,
patch
|
jhopkins
:
review+
|
Details | Diff | Splinter Review |
|
1.03 KB,
patch
|
jhopkins
:
review+
standard8
:
approval-comm-aurora+
standard8
:
approval-comm-esr10+
|
Details | Diff | Splinter Review |
|
3.16 KB,
patch
|
jhopkins
:
review+
|
Details | Diff | Splinter Review |
Way back just before we moved to libxul/ipc based builds, we had some hacks in our makefiles to get away with keep on being broken by pedantic compiler raised issues, when Firefox were disabling it for parts of libxul based builds. The hack was to add -disable-pedantic. We long since switched to libxul and IPC enabled builds, so we should just remove those hacks. Try server has been this way forever, if not a long time ;-)
Attachment #607164 -
Flags: review?(jhopkins)
|
Assignee | |
Comment 1•12 years ago
|
||
|
||
Updated•12 years ago
|
Attachment #607164 -
Flags: review?(jhopkins) → review+
|
|
||
Updated•12 years ago
|
Attachment #607165 -
Flags: review?(jhopkins) → review+
|
|
||
Comment 2•12 years ago
|
||
Per IRC, we'll also want to change the Linux 'release' mozconfigs at the end of the cycle when we release Thunderbird 12. Could change esr10 mozconfigs at the same time?
|
|
Assignee | |
Comment 3•12 years ago
|
||
Comment on attachment 607165 [details] [diff] [review] comm-central patch Checked in the comm-central patch: http://hg.mozilla.org/comm-central/rev/c7c25f9da0cf
|
|
Assignee | |
Comment 4•12 years ago
|
||
Comment on attachment 607164 [details] [diff] [review] Buildbot-configs patch Checked in: http://hg.mozilla.org/build/buildbot-configs/rev/d0594738b150
|
|
Assignee | |
Updated•12 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 14.0
|
|
Assignee | |
Comment 5•12 years ago
|
||
Comment on attachment 607165 [details] [diff] [review] comm-central patch [Triage Comment] We landed the configs on aurora as well, so we should take this there to be consistent.
Attachment #607165 -
Flags: approval-comm-aurora+
|
|
Assignee | |
Comment 6•12 years ago
|
||
(or rather, they landed before the merge)
|
|
Assignee | |
Comment 7•12 years ago
|
||
Checked into aurora: http://hg.mozilla.org/releases/comm-aurora/rev/2b4efa4fca28 Also setting flags so we track this for the 12 final release and the 12 ESR equivalent.
status-thunderbird13:
--- → fixed
tracking-thunderbird12:
--- → +
tracking-thunderbird-esr10:
--- → 12+
Whiteboard: [need final changes for 12 release & ESR 12 equivalent]
|
|
Assignee | |
Comment 8•12 years ago
|
||
This is the patch that's ready to land for release of 12/esr10.
Attachment #615889 -
Flags: review?(jhopkins)
|
|
Assignee | |
Comment 9•12 years ago
|
||
Due to the releases, I've landed the last patch pending review: http://hg.mozilla.org/build/buildbot-configs/rev/c6644699b3e5
status-thunderbird12:
--- → fixed
status-thunderbird-esr10:
--- → fixed
Whiteboard: [need final changes for 12 release & ESR 12 equivalent]
|
|
||
Updated•12 years ago
|
Attachment #615889 -
Flags: review?(jhopkins) → review+
|
|
Assignee | |
Comment 10•12 years ago
|
||
Comment on attachment 607165 [details] [diff] [review] comm-central patch [Triage Comment] Taking this onto esr as well, as we'll need it there, and currently its NPOTB.
Attachment #607165 -
Flags: approval-comm-esr10+
|
|
Assignee | |
Comment 11•12 years ago
|
||
Checked in: http://hg.mozilla.org/releases/comm-esr10/rev/8d17ead73857
You need to log in
before you can comment on or make changes to this bug.
Description
•