The default bug view has changed. See this FAQ.

Re-enable pedantic builds on Linux 32 bit mozconfigs

RESOLVED FIXED in Thunderbird 14.0

Status

Thunderbird
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

Trunk
Thunderbird 14.0

Thunderbird Tracking Flags

(thunderbird12+ fixed, thunderbird13 fixed, thunderbird-esr1012+ fixed)

Details

Attachments

(3 attachments)

(Assignee)

Description

5 years ago
Created attachment 607164 [details] [diff] [review]
Buildbot-configs patch

Way back just before we moved to libxul/ipc based builds, we had some hacks in our makefiles to get away with keep on being broken by pedantic compiler raised issues, when Firefox were disabling it for parts of libxul based builds.

The hack was to add -disable-pedantic.

We long since switched to libxul and IPC enabled builds, so we should just remove those hacks. Try server has been this way forever, if not a long time ;-)
Attachment #607164 - Flags: review?(jhopkins)
(Assignee)

Comment 1

5 years ago
Created attachment 607165 [details] [diff] [review]
comm-central patch
Assignee: nobody → mbanner
Status: NEW → ASSIGNED
Attachment #607165 - Flags: review?(jhopkins)
Attachment #607164 - Flags: review?(jhopkins) → review+
Attachment #607165 - Flags: review?(jhopkins) → review+
Per IRC, we'll also want to change the Linux 'release' mozconfigs at the end of the cycle when we release Thunderbird 12.
Could change esr10 mozconfigs at the same time?
(Assignee)

Comment 3

5 years ago
Comment on attachment 607165 [details] [diff] [review]
comm-central patch

Checked in the comm-central patch:

http://hg.mozilla.org/comm-central/rev/c7c25f9da0cf
(Assignee)

Comment 4

5 years ago
Comment on attachment 607164 [details] [diff] [review]
Buildbot-configs patch

Checked in:

http://hg.mozilla.org/build/buildbot-configs/rev/d0594738b150
(Assignee)

Updated

5 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 14.0
(Assignee)

Comment 5

5 years ago
Comment on attachment 607165 [details] [diff] [review]
comm-central patch

[Triage Comment]
We landed the configs on aurora as well, so we should take this there to be consistent.
Attachment #607165 - Flags: approval-comm-aurora+
(Assignee)

Comment 6

5 years ago
(or rather, they landed before the merge)
(Assignee)

Comment 7

5 years ago
Checked into aurora:

http://hg.mozilla.org/releases/comm-aurora/rev/2b4efa4fca28

Also setting flags so we track this for the 12 final release and the 12 ESR equivalent.
status-thunderbird13: --- → fixed
tracking-thunderbird12: --- → +
tracking-thunderbird-esr10: --- → 12+
Whiteboard: [need final changes for 12 release & ESR 12 equivalent]
(Assignee)

Comment 8

5 years ago
Created attachment 615889 [details] [diff] [review]
Fix buildbot-configs for esr/release

This is the patch that's ready to land for release of 12/esr10.
Attachment #615889 - Flags: review?(jhopkins)
(Assignee)

Comment 9

5 years ago
Due to the releases, I've landed the last patch pending review:

http://hg.mozilla.org/build/buildbot-configs/rev/c6644699b3e5
status-thunderbird12: --- → fixed
status-thunderbird-esr10: --- → fixed
Whiteboard: [need final changes for 12 release & ESR 12 equivalent]
Attachment #615889 - Flags: review?(jhopkins) → review+
(Assignee)

Comment 10

5 years ago
Comment on attachment 607165 [details] [diff] [review]
comm-central patch

[Triage Comment]
Taking this onto esr as well, as we'll need it there, and currently its NPOTB.
Attachment #607165 - Flags: approval-comm-esr10+
(Assignee)

Comment 11

5 years ago
Checked in:

http://hg.mozilla.org/releases/comm-esr10/rev/8d17ead73857
You need to log in before you can comment on or make changes to this bug.