Note: There are a few cases of duplicates in user autocompletion which are being worked on.

don't traverse a nsXULTemplateBuilder with an observed document

RESOLVED FIXED in mozilla14

Status

()

Core
XUL
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mccr8, Assigned: mccr8)

Tracking

(Blocks: 2 bugs)

Trunk
mozilla14
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [snappy])

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Created attachment 607193 [details]
nsXULTemplateBuilder CC graph blob

A blob rooted with a number of nsXULTemplateBuilders shows up in the CC graph all the time.  In the attached example, there are 47 nodes.  It turns out that the builder attaches itself as a listener, and so is being held live by the listener service.  In that case, we don't need to traverse it.
(Assignee)

Comment 1

5 years ago
Created attachment 607197 [details] [diff] [review]
if we have an observed document, stop traversal

Simple patch.  I'm just not sure if I should add a debug-mode check to see if the template builder is actually a registered listener or not, or if that's just such a fundamental thing that nobody will ever break it.  That would require, in the case where we decide to interrupt traverse, to iterate over all listeners and compare them to ourselves.
Assignee: nobody → continuation
(Assignee)

Comment 2

5 years ago
Created attachment 607794 [details] [diff] [review]
if we have an observed document, stop traversal
Attachment #607197 - Attachment is obsolete: true
(Assignee)

Comment 3

5 years ago
Comment on attachment 607794 [details] [diff] [review]
if we have an observed document, stop traversal

Ben, you are familiar with the cycle collector, and wrote the code I'm relying on here in Bug 416939, back in 2008, so you seem like a good reviewer.  Basically, whenever the template builder has an observed document, it is registered with the global observer service, which holds it alive, so we don't need to traverse it in the cycle collector.

This passed a try run along with some other patches of mine.
Attachment #607794 - Flags: review?(bent.mozilla)
Attachment #607794 - Flags: review?(bent.mozilla) → review+
(Assignee)

Comment 4

5 years ago
Thanks for the quick review!

https://hg.mozilla.org/integration/mozilla-inbound/rev/beb523be92e1
Target Milestone: --- → mozilla14
Whiteboard: [snappy]
https://hg.mozilla.org/mozilla-central/rev/beb523be92e1
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.