Closed Bug 737061 Opened 11 years ago Closed 11 years ago

Remove dependency on Services.jsm from tabbrowser.xml

Categories

(SeaMonkey :: Tabbed Browser, defect)

Product:
SeaMonkey
Component:
Tabbed Browser
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(seamonkey2.11 fixed)

Status:
RESOLVED FIXED
Milestone:
seamonkey2.11
Tracking Flags:
Tracking Status
seamonkey2.11 --- fixed

People

(Reporter: philip.chee, Assigned: philip.chee)

References

Details

Attachments

(1 file)

Patch v1.0 Fixit.
5.48 KB, patch
neil
: review+
Details | Diff | Splinter Review 
From Bug 735333 Comment 4:

> Please don't change tabbrowser.xml, I don't want it to use Services. (I know
> it does but I didn't notice KaiRo/Callek adding them. Oops.)
Make it so.
Attachment #607201 - Flags: review?(neil)
Comment on attachment 607201 [details] [diff] [review]
Patch v1.0 Fixit.

Thanks!

I wondered whether it was worth adding a field but fortunately they're lazy.
Attachment #607201 - Flags: review?(neil) → review+
Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/cb93d9dc9558
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
status-seamonkey2.11: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.11
Depends on: 735333
IMHO, removing Services.jsm usage is always a step back, thankfully I'm not responsible for the affected product any more.
Robert, you need to look at the larger picture and not simply cargo cult things around.
You need to log in before you can comment on or make changes to this bug.