Remove dependency on Services.jsm from tabbrowser.xml

RESOLVED FIXED in seamonkey2.11

Status

SeaMonkey
Tabbed Browser
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Philip Chee, Assigned: Philip Chee)

Tracking

Trunk
seamonkey2.11

SeaMonkey Tracking Flags

(seamonkey2.11 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
From Bug 735333 Comment 4:

> Please don't change tabbrowser.xml, I don't want it to use Services. (I know
> it does but I didn't notice KaiRo/Callek adding them. Oops.)
(Assignee)

Comment 1

6 years ago
Created attachment 607201 [details] [diff] [review]
Patch v1.0 Fixit.

Make it so.
Attachment #607201 - Flags: review?(neil)

Comment 2

6 years ago
Comment on attachment 607201 [details] [diff] [review]
Patch v1.0 Fixit.

Thanks!

I wondered whether it was worth adding a field but fortunately they're lazy.
Attachment #607201 - Flags: review?(neil) → review+
(Assignee)

Comment 3

6 years ago
Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/cb93d9dc9558
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
status-seamonkey2.11: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.11
Depends on: 735333

Comment 4

6 years ago
IMHO, removing Services.jsm usage is always a step back, thankfully I'm not responsible for the affected product any more.
(Assignee)

Comment 5

6 years ago
Robert, you need to look at the larger picture and not simply cargo cult things around.
You need to log in before you can comment on or make changes to this bug.