737175 - Make jemalloc build on ICS

Status: RESOLVED FIXED

(Core :: Memory Allocator, defect)

Description

[Michael Wu [:mwu]]

Attachment: Avoid name conflict with bionic's stdio.h

This is a patch from an anonymous silicon vendor contributor. It works for me. Other suggestions are welcome - we simply need to avoid a collision with __isthreaded which bionic defines in stdio.h. (why? because bionic)

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 607291 [details] [diff] [review]
Avoid name conflict with bionic's stdio.h

This is fine by me, but I'd like Mike to look at it too (at the least, for a heads up for the porting work he's doing).

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 607291 [details] [diff] [review]
Avoid name conflict with bionic's stdio.h

Review of attachment 607291 [details] [diff] [review]:
-----------------------------------------------------------------

::: memory/jemalloc/jemalloc.c
@@ +425,4 @@
>  #endif
>  
>  #ifdef MOZ_MEMORY_DARWIN
> +static const bool moz__isthreaded = true;

Just name it 'isthreaded'. It doesn't need to have a special prefixed name. And that's the name used in jemalloc2.

Comment 3

[Michael Wu [:mwu]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f163b1d6621e

Comment 4

[Mounir Lamouri (:mounir)]

https://hg.mozilla.org/mozilla-central/rev/f163b1d6621e