Closed Bug 737175 Opened 9 years ago Closed 9 years ago

Make jemalloc build on ICS

Categories

(Core :: Memory Allocator, defect)

All
Gonk (Firefox OS)
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla14

People

(Reporter: mwu, Assigned: mwu)

References

Details

Attachments

(1 file)

This is a patch from an anonymous silicon vendor contributor. It works for me. Other suggestions are welcome - we simply need to avoid a collision with __isthreaded which bionic defines in stdio.h. (why? because bionic)
Attachment #607291 - Flags: review?(khuey)
Comment on attachment 607291 [details] [diff] [review]
Avoid name conflict with bionic's stdio.h

This is fine by me, but I'd like Mike to look at it too (at the least, for a heads up for the porting work he's doing).
Attachment #607291 - Flags: review?(mh+mozilla)
Attachment #607291 - Flags: review?(khuey)
Attachment #607291 - Flags: review+
Comment on attachment 607291 [details] [diff] [review]
Avoid name conflict with bionic's stdio.h

Review of attachment 607291 [details] [diff] [review]:
-----------------------------------------------------------------

::: memory/jemalloc/jemalloc.c
@@ +425,4 @@
>  #endif
>  
>  #ifdef MOZ_MEMORY_DARWIN
> +static const bool moz__isthreaded = true;

Just name it 'isthreaded'. It doesn't need to have a special prefixed name. And that's the name used in jemalloc2.
Attachment #607291 - Flags: review?(mh+mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/f163b1d6621e
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Version: unspecified → Trunk
You need to log in before you can comment on or make changes to this bug.