737199 - Make gonk backend support ICS InputReader

Status: RESOLVED FIXED

(Core :: Widget, defect)

Description

[Michael Wu [:mwu]]

Attachment: Make gonk backend support ICS InputReader

This is a patch by an anonymous silicon vendor contributor. It's a bit messy but I will clean it up later when we stop depending on frameworks/base for our inputreading needs.

Comment 1

[Michael Wu [:mwu]]

Comment on attachment 607322 [details] [diff] [review]
Make gonk backend support ICS InputReader

r=me cuz I can.

Comment 2

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: part 1: Import the Ice Cream Sandwich version of InputReader and friends to get off the treadmill of an internal interface

Also r=mwu.

Comment 3

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: part 2: Port Gonk nsAppShell to the ICS InputReader

The parts I didn't write are r=me.  I fixed the TODO stuff, which could use another pair of eyes, so r?mwu.

Comment 4

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

https://hg.mozilla.org/mozilla-central/rev/b70043c5cc01

Part 1 here is the last patch needed for ICS compat in upstream m-c, please to be reviewing in a timely fashion :).

Comment 5

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

er, part 2

Comment 6

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: part 2: Port Gonk nsAppShell to the ICS InputReader

No code changes, just updated hg metadata.

Comment 7

[Andreas Gal :gal]

Comment on attachment 609093 [details] [diff] [review]
part 2: Port Gonk nsAppShell to the ICS InputReader

injectInputEvent needs a little indentation love

Comment 8

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Landed with indentation fix.

https://hg.mozilla.org/mozilla-central/rev/0e0773c0188f

mwu please file followups if you have more comments.