The default bug view has changed. See this FAQ.

Make gonk backend support ICS InputReader

RESOLVED FIXED

Status

()

Core
Widget
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mwu, Assigned: mwu)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 2 obsolete attachments)

(Assignee)

Description

5 years ago
Created attachment 607322 [details] [diff] [review]
Make gonk backend support ICS InputReader

This is a patch by an anonymous silicon vendor contributor. It's a bit messy but I will clean it up later when we stop depending on frameworks/base for our inputreading needs.
(Assignee)

Comment 1

5 years ago
Comment on attachment 607322 [details] [diff] [review]
Make gonk backend support ICS InputReader

r=me cuz I can.
Attachment #607322 - Flags: review+
Created attachment 609087 [details] [diff] [review]
part 1: Import the Ice Cream Sandwich version of InputReader and friends to get off the treadmill of an internal interface

Also r=mwu.
Attachment #607322 - Attachment is obsolete: true
Attachment #609087 - Flags: review+
Created attachment 609088 [details] [diff] [review]
part 2: Port Gonk nsAppShell to the ICS InputReader

The parts I didn't write are r=me.  I fixed the TODO stuff, which could use another pair of eyes, so r?mwu.
Attachment #609088 - Flags: review?(mwu)
https://hg.mozilla.org/mozilla-central/rev/b70043c5cc01

Part 1 here is the last patch needed for ICS compat in upstream m-c, please to be reviewing in a timely fashion :).
er, part 2
Created attachment 609093 [details] [diff] [review]
part 2: Port Gonk nsAppShell to the ICS InputReader

No code changes, just updated hg metadata.
Attachment #609088 - Attachment is obsolete: true
Attachment #609088 - Flags: review?(mwu)
Attachment #609093 - Flags: review?(mwu)

Comment 7

5 years ago
Comment on attachment 609093 [details] [diff] [review]
part 2: Port Gonk nsAppShell to the ICS InputReader

injectInputEvent needs a little indentation love
Attachment #609093 - Flags: review?(mwu) → review+
Landed with indentation fix.

https://hg.mozilla.org/mozilla-central/rev/0e0773c0188f

mwu please file followups if you have more comments.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Updated

5 years ago
Blocks: 739139
(Assignee)

Updated

5 years ago
Blocks: 739417
(Assignee)

Updated

5 years ago
Blocks: 745077
You need to log in before you can comment on or make changes to this bug.