Closed Bug 737199 Opened 8 years ago Closed 8 years ago

Make gonk backend support ICS InputReader

Categories

(Core :: Widget, defect)

All
Gonk (Firefox OS)
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: mwu, Assigned: mwu)

References

Details

Attachments

(2 files, 2 obsolete files)

This is a patch by an anonymous silicon vendor contributor. It's a bit messy but I will clean it up later when we stop depending on frameworks/base for our inputreading needs.
Comment on attachment 607322 [details] [diff] [review]
Make gonk backend support ICS InputReader

r=me cuz I can.
Attachment #607322 - Flags: review+
The parts I didn't write are r=me.  I fixed the TODO stuff, which could use another pair of eyes, so r?mwu.
Attachment #609088 - Flags: review?(mwu)
https://hg.mozilla.org/mozilla-central/rev/b70043c5cc01

Part 1 here is the last patch needed for ICS compat in upstream m-c, please to be reviewing in a timely fashion :).
No code changes, just updated hg metadata.
Attachment #609088 - Attachment is obsolete: true
Attachment #609088 - Flags: review?(mwu)
Attachment #609093 - Flags: review?(mwu)
Comment on attachment 609093 [details] [diff] [review]
part 2: Port Gonk nsAppShell to the ICS InputReader

injectInputEvent needs a little indentation love
Attachment #609093 - Flags: review?(mwu) → review+
Landed with indentation fix.

https://hg.mozilla.org/mozilla-central/rev/0e0773c0188f

mwu please file followups if you have more comments.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Blocks: 739139
Blocks: 739417
Blocks: 745077
You need to log in before you can comment on or make changes to this bug.