Last Comment Bug 737221 - GC: HeapId::pre barrier needs to check for strings
: GC: HeapId::pre barrier needs to check for strings
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla14
Assigned To: Terrence Cole [:terrence]
:
Mentors:
Depends on:
Blocks: 673454
  Show dependency treegraph
 
Reported: 2012-03-19 15:22 PDT by Terrence Cole [:terrence]
Modified: 2012-03-21 03:38 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
v0 (1.59 KB, patch)
2012-03-20 14:56 PDT, Terrence Cole [:terrence]
wmccloskey: review+
Details | Diff | Review

Description Terrence Cole [:terrence] 2012-03-19 15:22:56 PDT
We should never hit the HeapId::pre barrier in normal engine usage.  If we ever do start using this, the fact that strings are not caught here will be a bug.
Comment 1 Terrence Cole [:terrence] 2012-03-20 14:56:40 PDT
Created attachment 607733 [details] [diff] [review]
v0

I'm not sure if the JS_UNLIKELYs make sense after this patch.  I don't really know what the common case is here -- JSID_IS_VOID maybe?  Perhaps, if we do know what to expect as a common case, it would be better to detect it and exit early with a single branch here?
Comment 2 Terrence Cole [:terrence] 2012-03-20 16:09:19 PDT
http://hg.mozilla.org/integration/mozilla-inbound/rev/65e02a60d3dd
Comment 3 Mounir Lamouri (:mounir) 2012-03-21 03:38:38 PDT
https://hg.mozilla.org/mozilla-central/rev/65e02a60d3dd

Note You need to log in before you can comment on or make changes to this bug.