Closed Bug 737221 Opened 9 years ago Closed 9 years ago

GC: HeapId::pre barrier needs to check for strings

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla14

People

(Reporter: terrence, Assigned: terrence)

References

Details

Attachments

(1 file)

We should never hit the HeapId::pre barrier in normal engine usage.  If we ever do start using this, the fact that strings are not caught here will be a bug.
Blocks: 673454
Attached patch v0Splinter Review
I'm not sure if the JS_UNLIKELYs make sense after this patch.  I don't really know what the common case is here -- JSID_IS_VOID maybe?  Perhaps, if we do know what to expect as a common case, it would be better to detect it and exit early with a single branch here?
Attachment #607733 - Flags: review?(wmccloskey)
Attachment #607733 - Flags: review?(wmccloskey) → review+
https://hg.mozilla.org/mozilla-central/rev/65e02a60d3dd
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
You need to log in before you can comment on or make changes to this bug.