GC: HeapId::pre barrier needs to check for strings

RESOLVED FIXED in mozilla14

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: terrence, Assigned: terrence)

Tracking

Trunk
mozilla14
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
We should never hit the HeapId::pre barrier in normal engine usage.  If we ever do start using this, the fact that strings are not caught here will be a bug.
(Assignee)

Updated

5 years ago
Blocks: 673454
(Assignee)

Comment 1

5 years ago
Created attachment 607733 [details] [diff] [review]
v0

I'm not sure if the JS_UNLIKELYs make sense after this patch.  I don't really know what the common case is here -- JSID_IS_VOID maybe?  Perhaps, if we do know what to expect as a common case, it would be better to detect it and exit early with a single branch here?
Attachment #607733 - Flags: review?(wmccloskey)
Attachment #607733 - Flags: review?(wmccloskey) → review+
(Assignee)

Comment 2

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/65e02a60d3dd
https://hg.mozilla.org/mozilla-central/rev/65e02a60d3dd
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
You need to log in before you can comment on or make changes to this bug.