737260 - Concurrent tabs preference doesn't update correctly

Status: RESOLVED FIXED

(SeaMonkey :: Session Restore, defect)

Description

[[e-mail]]

I knew I had trouble getting the onselect and onchange events to update the preference window correctly and obviously when tweaking the effect for one preference value I overlooked that another possible value had stopped working.

This made the recent uplift so hopefully I have my tracking flags correct.

Comment 1

[[e-mail]]

Attachment: Proposed patch

Instead of fiddling around with onchange and Startup I switched to onsyncfrom/topreference which are more reliable.

I got rid of onselect because it fires when I don't want it to. I used an onclick handler although that doesn't fire in some cases, and for some reason the keyboard accelerator doesn't change the selected radio the first time.

I also added some aria love which I had forgotten on the previous patch.

Comment 2

[Ian Neal]

The strange thing I get when starting the prefs window is the following in the error console:
Error: document.getElementById("navigator_pane").ReadConcurrentTabs is not a function
Source File: chrome://global/content/bindings/preferences.xml
Line: 402
But using JS debugger it definitely does use it, do we still need the preference on the textbox?

Comment 3

[[e-mail]]

Pushed changeset f548f391b86c to comm-central.

(In reply to Ian Neal from comment #2)
> The strange thing I get when starting the prefs window is the following in
> the error console:
> Error: document.getElementById("navigator_pane").ReadConcurrentTabs is not a
> function
> Source File: chrome://global/content/bindings/preferences.xml
> Line: 402
Strange; remind me to check my other builds when I update them next week.