The default bug view has changed. See this FAQ.

Concurrent tabs preference doesn't update correctly

RESOLVED FIXED

Status

SeaMonkey
Session Restore
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: neil@parkwaycc.co.uk, Assigned: neil@parkwaycc.co.uk)

Tracking

Dependency tree / graph

SeaMonkey Tracking Flags

(seamonkey2.10 affected, seamonkey2.11 affected)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
I knew I had trouble getting the onselect and onchange events to update the preference window correctly and obviously when tweaking the effect for one preference value I overlooked that another possible value had stopped working.

This made the recent uplift so hopefully I have my tracking flags correct.
(Assignee)

Comment 1

5 years ago
Created attachment 607375 [details] [diff] [review]
Proposed patch

Instead of fiddling around with onchange and Startup I switched to onsyncfrom/topreference which are more reliable.

I got rid of onselect because it fires when I don't want it to. I used an onclick handler although that doesn't fire in some cases, and for some reason the keyboard accelerator doesn't change the selected radio the first time.

I also added some aria love which I had forgotten on the previous patch.
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #607375 - Flags: review?(iann_bugzilla)

Updated

5 years ago
Attachment #607375 - Flags: review?(iann_bugzilla) → review+

Comment 2

5 years ago
The strange thing I get when starting the prefs window is the following in the error console:
Error: document.getElementById("navigator_pane").ReadConcurrentTabs is not a function
Source File: chrome://global/content/bindings/preferences.xml
Line: 402
But using JS debugger it definitely does use it, do we still need the preference on the textbox?
(Assignee)

Comment 3

5 years ago
Pushed changeset f548f391b86c to comm-central.

(In reply to Ian Neal from comment #2)
> The strange thing I get when starting the prefs window is the following in
> the error console:
> Error: document.getElementById("navigator_pane").ReadConcurrentTabs is not a
> function
> Source File: chrome://global/content/bindings/preferences.xml
> Line: 402
Strange; remind me to check my other builds when I update them next week.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Updated

4 years ago
Depends on: 868486
You need to log in before you can comment on or make changes to this bug.