737271 - Stray code on /featured (Featured Reps archive page)

Status: VERIFIED FIXED

Description

[Stephen Donner [:stephend]]

Created attachment 607383 [details]
Screenshot

There's some stray code/markup, on https://reps-dev.allizom.org/featured/:

<input type="hidden" name="assertion" id="id_assertion" />

Comment 1

[Giorgos Logiotatidis [:giorgos]]

Cannot verify this bug, probably a later commit fixed that. 

Thanks for reporting!

Comment 2

[Giorgos Logiotatidis [:giorgos]]

Cannot verify this bug, probably a later commit fixed that. 

Thanks for reporting!

Comment 3

[Stephen Donner [:stephend]]

Verified WFM; sorry, I meant to close this earlier.

Comment 4

[raymond [:retornam] (inactive)]

Created attachment 611051 [details]
stageScreenshot

Re-opening this bug as it happens whenever you click on the Sign-In button and  the Browser-ID popup isn't shown. See attached screenshot

Comment 5

[Giorgos Logiotatidis [:giorgos]]

Raymond,

Thanks for providing more info. I still cannot reproduce this one though :( What do you mean by "the Browser-ID popup isn't shown"? Does the browserid js get loaded?

Since the <input> field is of type "hidden" shouldn't that be always hidden? Maybe that a crazy ffx bug?

Comment 6

[raymond [:retornam] (inactive)]

(In reply to Giorgos Logiotatidis [:giorgos] from comment #5)
> Raymond,
> 
> Thanks for providing more info. I still cannot reproduce this one though :(
> What do you mean by "the Browser-ID popup isn't shown"? Does the browserid
> js get loaded?

When I click on the BrowserID sign-in, A pop-up window is shown that enables me to login with BrowserID. This bug happens only when that pop-up window is not shown.
> 
> Since the <input> field is of type "hidden" shouldn't that be always hidden?
> Maybe that a crazy ffx bug?

Comment 7

[Giorgos Logiotatidis [:giorgos]]

Raymond,

Can you think of a reason why the BrowserID pop-up is not shown? Do you have any plugins that prevent it from showing, or any JS blockers that prevent the browserid js from being loaded?

Thanks!

Comment 8

[Stephen Donner [:stephend]]

I'm untargetting this, as it's really hard to reliably reproduce; feels like a race condition, or something.  Also, nobody has complained about it in production, it's even lower priority.

Comment 9

[Giorgos Logiotatidis [:giorgos]]

I believe that this was related to playdoh's form monkeypatching to mark them safe. We pushed a newer version of playdoh, with changes on the monkeypatching code. I'll leave this open for a month and if nobody manages to reproduce it, I'll mark it as fixed.

Please if you come across this issue, comment on this bug. Thanks!

Comment 10

[Giorgos Logiotatidis [:giorgos]]

Closing this bug after 1 month and a new release.

Comment 11

[Ben (:bensternthal)]

Poked around a bit, still unable to reproduce and no one has reported it occurring again.

Verifying.