Closed Bug 737271 Opened 13 years ago Closed 13 years ago

Stray code on /featured (Featured Reps archive page)

Categories

(Mozilla Reps Graveyard :: reps.mozilla.org, task)

task
Not set
major

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: stephend, Assigned: giorgos)

References

()

Details

Attachments

(2 files)

Attached image Screenshot
There's some stray code/markup, on https://reps-dev.allizom.org/featured/: <input type="hidden" name="assertion" id="id_assertion" />
Cannot verify this bug, probably a later commit fixed that. Thanks for reporting!
Cannot verify this bug, probably a later commit fixed that. Thanks for reporting!
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → WORKSFORME
Verified WFM; sorry, I meant to close this earlier.
Status: RESOLVED → VERIFIED
Attached image stageScreenshot
Re-opening this bug as it happens whenever you click on the Sign-In button and the Browser-ID popup isn't shown. See attached screenshot
Status: VERIFIED → REOPENED
Resolution: WORKSFORME → ---
Raymond, Thanks for providing more info. I still cannot reproduce this one though :( What do you mean by "the Browser-ID popup isn't shown"? Does the browserid js get loaded? Since the <input> field is of type "hidden" shouldn't that be always hidden? Maybe that a crazy ffx bug?
(In reply to Giorgos Logiotatidis [:giorgos] from comment #5) > Raymond, > > Thanks for providing more info. I still cannot reproduce this one though :( > What do you mean by "the Browser-ID popup isn't shown"? Does the browserid > js get loaded? When I click on the BrowserID sign-in, A pop-up window is shown that enables me to login with BrowserID. This bug happens only when that pop-up window is not shown. > > Since the <input> field is of type "hidden" shouldn't that be always hidden? > Maybe that a crazy ffx bug?
Raymond, Can you think of a reason why the BrowserID pop-up is not shown? Do you have any plugins that prevent it from showing, or any JS blockers that prevent the browserid js from being loaded? Thanks!
I'm untargetting this, as it's really hard to reliably reproduce; feels like a race condition, or something. Also, nobody has complained about it in production, it's even lower priority.
Version: 0.2 - Skon → unspecified
Assignee: nobody → giorgos
I believe that this was related to playdoh's form monkeypatching to mark them safe. We pushed a newer version of playdoh, with changes on the monkeypatching code. I'll leave this open for a month and if nobody manages to reproduce it, I'll mark it as fixed. Please if you come across this issue, comment on this bug. Thanks!
Closing this bug after 1 month and a new release.
Status: REOPENED → RESOLVED
Closed: 13 years ago13 years ago
Resolution: --- → FIXED
Poked around a bit, still unable to reproduce and no one has reported it occurring again. Verifying.
Status: RESOLVED → VERIFIED
Product: Mozilla Reps → Mozilla Reps Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: