Closed Bug 737314 Opened 12 years ago Closed 12 years ago

[SeaMonkey] 2 "test_bug650776.html | Wrong sanitizer result"

Categories

(MailNews Core :: Networking, defect, P2)

Product:
MailNews Core
Component:
Networking
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
Thunderbird 14.0

People

(Reporter: sgautherie, Assigned: hsivonen)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [perma-orange])

Attachments

(1 file, 1 obsolete file)

Route around nsIURI for cid: URLs
2.91 KB, patch
smaug
: review+
Details | Diff | Splinter Review 
{
305 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/content/base/test/chrome/test_bug650776.html | Wrong sanitizer result 8 - got <html><head></head><body><img></body></html>, expected <html><head></head><body><img src="cid:foo"></body></html>

310 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/content/base/test/chrome/test_bug650776.html | Wrong sanitizer result 13 - got <html><head></head><body></body></html>, expected <html><head></head><body background="cid:foo"></body></html>
}

Fwiw, I noticed (at least) the following errors:
{
Security Error: Content at moz-nullprincipal:{9503dc11-62d7-41d9-95d2-f413b7ab7798} may not load or link to about:blank.

Security Error: Content at moz-nullprincipal:{3611fea8-39b1-4c39-ab0f-3bd3988fed0b} may not load or link to about:blank.
}
Are they expected?
(In reply to Serge Gautherie (:sgautherie) from comment #0)
> {
> 305 ERROR TEST-UNEXPECTED-FAIL |
> chrome://mochitests/content/chrome/content/base/test/chrome/test_bug650776.
> html | Wrong sanitizer result 8 - got
> <html><head></head><body><img></body></html>, expected
> <html><head></head><body><img src="cid:foo"></body></html>
> 
> 310 ERROR TEST-UNEXPECTED-FAIL |
> chrome://mochitests/content/chrome/content/base/test/chrome/test_bug650776.
> html | Wrong sanitizer result 13 - got
> <html><head></head><body></body></html>, expected <html><head></head><body
> background="cid:foo"></body></html>
> }

This is weird. Works on m-c. Could it be that comm-central has a special implementation class for cid: URLs and the SchemeIs method of that class is broken?

> Fwiw, I noticed (at least) the following errors:
> {
> Security Error: Content at
> moz-nullprincipal:{9503dc11-62d7-41d9-95d2-f413b7ab7798} may not load or
> link to about:blank.
> 
> Security Error: Content at
> moz-nullprincipal:{3611fea8-39b1-4c39-ab0f-3bd3988fed0b} may not load or
> link to about:blank.
> }
> Are they expected?

This is expected (albeit annoying) behavior. Bug 733935.
Attached patch Untested supposed fix (obsolete) — — Splinter Review 
Assignee: nobody → hsivonen
Status: NEW → ASSIGNED

    
    

    
  
Comment on attachment 607468 [details] [diff] [review]
Untested supposed fix

This patch doesn't actually fix the problem. Sigh.

        Attachment #607468 -
        Attachment is obsolete: true

    
    

    
  
(In reply to Henri Sivonen (:hsivonen) from comment #3)
> This patch doesn't actually fix the problem. Sigh.

(Yet, if the patch is correct, we could as well do it...)

    
    

    
  
The code that's causing the problem is the fix for bug 189358.

    
    

    
  
Does this mean SeaMonkey is in some kind a suboptimal situation with that MailNews code interfering in its Browser part (where it shouldn't)?

    
    

    
  
(In reply to Serge Gautherie (:sgautherie) from comment #7)
> Does this mean SeaMonkey is in some kind a suboptimal situation with that
> MailNews code interfering in its Browser part (where it shouldn't)?

When only mozilla-central code is running, cid: URLs are generic unknown URLs. When comm-central code has been loaded, too, there's an intentionally bogus implementation of cid: participating in the nsIURI factory.

This isn't really a "browser part". The feature whose test fails is meant for mailnews use, but I previously tested it using mozilla-central-only code, because I didn't realize comm-central would inject intentionally bogus stuff into the nsIURI factory.

    
    

    
  
(In reply to Henri Sivonen (:hsivonen) from comment #8)

Good then. Thanks for the explanation..
Depends on: 189358

    
    

    
  
Comment on attachment 607492 [details] [diff] [review]
Route around nsIURI for cid: URLs

See http://mxr.mozilla.org/comm-central/source/mailnews/base/src/nsCidProtocolHandler.cpp?force=1#71 for the reason why cid: nsIURIs are useless when comm-central code participates.

        Attachment #607492 -
        Flags: review?(bugs)

    
    

    
  
Comment on attachment 607492 [details] [diff] [review]
Route around nsIURI for cid: URLs

Horrible but ok.

        Attachment #607492 -
        Flags: review?(bugs) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/2906d8671454
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED

    
    

    
  
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1332369210.1332371127.13878.gz
OS X 10.5 comm-central-trunk debug test mochitest-other on 2012/03/21 15:33:30

V.Fixed
Status: RESOLVED → VERIFIED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: