Last Comment Bug 737396 - Remove the unnecessary and incorrect 'service,' at the start of cloud file category definitions
: Remove the unnecessary and incorrect 'service,' at the start of cloud file ca...
Status: RESOLVED FIXED
:
Product: Thunderbird
Classification: Client Software
Component: Message Compose Window (show other bugs)
: Trunk
: All All
: -- normal (vote)
: Thunderbird 14.0
Assigned To: Mark Banner (:standard8)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-03-20 06:29 PDT by Mark Banner (:standard8)
Modified: 2012-03-20 07:20 PDT (History)
1 user (show)
standard8: in‑testsuite+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
fixed


Attachments
The fix (2.12 KB, patch)
2012-03-20 06:29 PDT, Mark Banner (:standard8)
mconley: review+
standard8: approval‑comm‑aurora+
Details | Diff | Review

Description Mark Banner (:standard8) 2012-03-20 06:29:57 PDT
Created attachment 607521 [details] [diff] [review]
The fix

In our manifest files, the cloud providers are registered against categories with "service," at the start.

This is wrong - the cloud providers are created as instances, and the "service," never actually gets used - it just gets stripped from the id when loading the category.

Attached is the patch to remove this.
Comment 1 Mike Conley (:mconley) - (Away until June 29th) 2012-03-20 06:32:59 PDT
Comment on attachment 607521 [details] [diff] [review]
The fix

This looks right to me.  I don't think we ever strip or inject "service" in other places, so I think we've got our bases covered.

Thanks!
Comment 2 Mark Banner (:standard8) 2012-03-20 06:58:48 PDT
Checked in:

http://hg.mozilla.org/comm-central/rev/5fe8af14e493
Comment 3 Mark Banner (:standard8) 2012-03-20 06:59:20 PDT
Comment on attachment 607521 [details] [diff] [review]
The fix

[Triage Comment]
Going to take this on aurora as well, to avoid any confusion wrt add-ons.
Comment 4 Mark Banner (:standard8) 2012-03-20 07:20:09 PDT
Checked in: http://hg.mozilla.org/releases/comm-aurora/rev/2aa87c700865

Note You need to log in before you can comment on or make changes to this bug.