Closed Bug 737396 Opened 9 years ago Closed 9 years ago

Remove the unnecessary and incorrect 'service,' at the start of cloud file category definitions

Categories

(Thunderbird :: Message Compose Window, defect)

defect
Not set
normal

Tracking

(thunderbird13 fixed)

RESOLVED FIXED
Thunderbird 14.0
Tracking Status
thunderbird13 --- fixed

People

(Reporter: standard8, Assigned: standard8)

Details

Attachments

(1 file)

Attached patch The fixSplinter Review
In our manifest files, the cloud providers are registered against categories with "service," at the start.

This is wrong - the cloud providers are created as instances, and the "service," never actually gets used - it just gets stripped from the id when loading the category.

Attached is the patch to remove this.
Attachment #607521 - Flags: review?(mconley)
Comment on attachment 607521 [details] [diff] [review]
The fix

This looks right to me.  I don't think we ever strip or inject "service" in other places, so I think we've got our bases covered.

Thanks!
Attachment #607521 - Flags: review?(mconley) → review+
Checked in:

http://hg.mozilla.org/comm-central/rev/5fe8af14e493
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 14.0
Comment on attachment 607521 [details] [diff] [review]
The fix

[Triage Comment]
Going to take this on aurora as well, to avoid any confusion wrt add-ons.
Attachment #607521 - Flags: approval-comm-aurora+
You need to log in before you can comment on or make changes to this bug.