The default bug view has changed. See this FAQ.

Remove the unnecessary and incorrect 'service,' at the start of cloud file category definitions

RESOLVED FIXED in Thunderbird 14.0

Status

Thunderbird
Message Compose Window
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

Trunk
Thunderbird 14.0
Bug Flags:
in-testsuite +

Thunderbird Tracking Flags

(thunderbird13 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 607521 [details] [diff] [review]
The fix

In our manifest files, the cloud providers are registered against categories with "service," at the start.

This is wrong - the cloud providers are created as instances, and the "service," never actually gets used - it just gets stripped from the id when loading the category.

Attached is the patch to remove this.
Attachment #607521 - Flags: review?(mconley)
Comment on attachment 607521 [details] [diff] [review]
The fix

This looks right to me.  I don't think we ever strip or inject "service" in other places, so I think we've got our bases covered.

Thanks!
Attachment #607521 - Flags: review?(mconley) → review+
(Assignee)

Comment 2

5 years ago
Checked in:

http://hg.mozilla.org/comm-central/rev/5fe8af14e493
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 14.0
(Assignee)

Comment 3

5 years ago
Comment on attachment 607521 [details] [diff] [review]
The fix

[Triage Comment]
Going to take this on aurora as well, to avoid any confusion wrt add-ons.
Attachment #607521 - Flags: approval-comm-aurora+
(Assignee)

Comment 4

5 years ago
Checked in: http://hg.mozilla.org/releases/comm-aurora/rev/2aa87c700865
status-thunderbird13: --- → fixed
You need to log in before you can comment on or make changes to this bug.