737404 - signing server fails to start without logfile option

Status: RESOLVED WONTFIX

(Release Engineering :: General, defect, P4)

Description

[[e-mail] (:bhearsum)]

mac-signing1:dep-key-signing-server-2 cltsign$  bin/python tools/release/signing/signing-server.py -d signing.ini -v               
gpg passphrase: 
2012-03-20 06:50:04,076 - INFO - checking gpg passphrase
2012-03-20 06:50:04,091 - DEBUG - 8622: ['/Users/cltsign/instances/dep-key-signing-server-2/bin/python2.6', '/Users/cltsign/instances/dep-key-signing-server-2/tools/release/signing/signscript.py', '-c', '/Users/cltsign/instances/dep-key-signing-server-2/signscript.ini', 'gpg', '/Users/cltsign/instances/dep-key-signing-server-2/test-files/test.mar', '/tmp/tmp5Ui88Z/test.mar', '/Users/cltsign/instances/dep-key-signing-server-2/test-files/test.mar']
2012-03-20 06:50:04,342 - DEBUG - 8622: Success!
2012-03-20 06:50:04,343 - INFO - gpg passphrase OK
dmg passphrase: 
2012-03-20 06:50:05,484 - INFO - checking dmg passphrase
2012-03-20 06:50:05,490 - DEBUG - 8624: ['/Users/cltsign/instances/dep-key-signing-server-2/bin/python2.6', '/Users/cltsign/instances/dep-key-signing-server-2/tools/release/signing/signscript.py', '-c', '/Users/cltsign/instances/dep-key-signing-server-2/signscript.ini', 'dmg', '/Users/cltsign/instances/dep-key-signing-server-2/test-files/test.tar', '/tmp/tmp6DRn0P/test.tar', '/Users/cltsign/instances/dep-key-signing-server-2/test-files/test.tar']
2012-03-20 06:50:06,241 - DEBUG - 8624: Success!
2012-03-20 06:50:06,242 - INFO - dmg passphrase OK
Traceback (most recent call last):
  File "tools/release/signing/signing-server.py", line 1001, in <module>
    logfile = os.path.abspath(options.logfile)
  File "/Users/cltsign/instances/dep-key-signing-server-2/bin/../lib/python2.6/posixpath.py", line 336, in abspath
    if not isabs(path):
  File "/Users/cltsign/instances/dep-key-signing-server-2/bin/../lib/python2.6/posixpath.py", line 52, in isabs
    return s.startswith('/')
AttributeError: 'NoneType' object has no attribute 'startswith'


Works fine if I add "-l signing.log".

Comment 1

[Chris AtLee [:catlee]]

heh, this is kind of desirable behaviour, although I didn't code it this way.

you've got '-d' in there, which will run in detached mode. it makes sense to force a log file in that case I think, although this should be checked explicitly further up and give a more useful error message :)

Comment 2

[Mihai Tabara [:mtabara]⌚️GMT]

I think this bug outlived its usefulness.
Closing this, feel free to reopen if I'm wrong.